Repository navigation
Let git read the tree the runner checked out - #36
Merged
Merged
Conversation
The first release build got as far as configuring wine and then stopped:
fatal: detected dubious ownership in repository at
'/opt/wine64/drive_c/electrum-doi'
The checkout belongs to the runner user, the container runs as root, and git
refuses a working tree it does not own. build-electrum-git.sh takes the
version from `git describe --tags`, so that is where the build ends -- with
no hint that ownership was the problem.
It does not happen locally: Docker Desktop maps the mount to the calling
user, so the check passes and the trap only shows up on a Linux runner.
Set through GIT_CONFIG_COUNT/KEY/VALUE on the container rather than by
writing a .gitconfig into the image or a safe.directory line into the tree,
so nothing the build itself sees changes.
Reproduced before and after in a debian:trixie container with the tree
chowned to another uid: `git describe` fails with that exact message, and
returns dc4.1.7 with the variables set.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first release build (run 35366242511) configured wine, installed pyinstaller, and then stopped:
The checkout belongs to the runner user, the container runs as root, and git refuses a working tree it does not own.
build-electrum-git.shtakes the version fromVERSION=`git describe --tags --dirty --always`so that is exactly where it ends — and the message says nothing about the build, which is why it reads like a compiler failure.
It cannot happen locally. Docker Desktop maps the mount to the calling user, so the ownership check passes. The trap only appears on a Linux runner, which is the first time this build has ever run on one.
Reproduced, then fixed
In a
debian:trixiecontainer with the tree chowned to another uid:Set through
GIT_CONFIG_COUNT/GIT_CONFIG_KEY_0/GIT_CONFIG_VALUE_0on the container rather than by writing a.gitconfiginto the image or asafe.directoryline into the tree, so nothing the build itself sees changes — which matters when the point of the exercise is comparing its output byte for byte.Meanwhile, the local build finished
Once this is merged I will dispatch the workflow on
dc4.1.7again and compare against these three.🤖 Generated with Claude Code