Repository navigation
Take ownership of dist before writing the checksums beside it - #37
Merged
Merged
Conversation
The build now runs; the step after it does not:
tee: SHA256SUMS: Permission denied
The container writes dist/ as root, so the runner user can read the binaries
-- sha256sum printed all three -- but cannot add a file next to them. One
chown, and the artifact upload that follows gets its SHA256SUMS.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build now runs (run 35370252482 got past
git describeand produced all three binaries). The step after it did not:The container writes
dist/as root. The runner user can read the binaries —sha256sumprinted all three — but cannot add a file beside them. Onechown, and the artifact upload that follows gets itsSHA256SUMS.The run was worth having anyway
Those three hashes do not match the local build, and the sizes differ by a consistent amount:
.exe-portable.exe-setup.exeSame number twice is not noise.
deterministic.specbundles the plugin directory wholesale:and my working tree had 16
__pycache__directories with 25.pycfiles in there, ~180 KB uncompressed. Their suffix says where they came from:cpython-39. The Windows build runs Python 3.8 (python38.dll) — these are from my own test runs against that tree, not from the build.So the first comparison this project has ever run found contamination in the local build, which is exactly the sort of thing it exists to find. A rebuild from a pristine clone of the tag is running now; if it matches the runner, the build is reproducible and the released binaries come from the clean tree.
Worth noting for later: nothing stops this happening again, and the 4.1.6 binaries were built in the same tree. A
git clean -xdf(or building from a fresh clone) before a release build would make it impossible — probably belongs inbuild.shrather than in a habit.🤖 Generated with Claude Code