Repository navigation
Put the hashes where someone will look for them - #38
Merged
Merged
Conversation
They exist to be compared against a local build of the same tag, and they were going into an annotation and 20,000 lines of wine output. Now they go into the run's summary page as a table with file, size and sha256, under a heading naming the ref that was built. Checked by cutting the block out of the workflow and running it against the 4.1.7 binaries: the table renders, stat -c%s and sha256sum agree with what the release carries. The heading falls back to the dispatch input when `git describe` cannot answer, because an empty code span is a silly way to discover git is missing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You asked why the run page carries no summary. It does not, and it should — the hashes exist to be compared against a local build of the same tag, and they were going into an annotation plus twenty thousand lines of wine output.
Now they go into
$GITHUB_STEP_SUMMARY, which is the first thing on the run page:Those are the real numbers — the block was cut out of the workflow and run against the released 4.1.7 binaries, so
stat -c%sandsha256sumare confirmed to agree with what the release carries rather than assumed to.The heading falls back to the dispatch input when
git describecannot answer. git is on the runner, but an empty code span is a silly way to discover it is not.The
::noticeannotation goes away: it concatenated all three hashes onto one line, which was hard to read and harder to compare.🤖 Generated with Claude Code