Repository navigation
DWG reader: read RTEXT data into UnknownEntity - #1285
Open
jarrett-meyer wants to merge 1 commit into
Open
jarrett-meyer wants to merge 1 commit into
jarrett-meyer wants to merge 1 commit into
Conversation
RTEXT (Express Tools remote text) has no class in the library and is read as an UnknownEntity, losing its data. Dispatch it through the readUnlistedType switch with a DxfFileToken constant, read the common entity data, then its insertion point, normal, rotation, height, flags, contents (a DIESEL expression or a file name) and text style handle into UnknownEntity.RText. A read failure only reports a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTEXT (Express Tools remote text) has no class in the library and is read as
UnknownEntity, so its data is lost. Split out of #1272 as requested.RTEXT is dispatched through the
readUnlistedTypeswitch with a newDxfFileToken.EntityRTextconstant. After the common entity data, the reader reads the insertion point, normal, rotation, height, flags, contents (a DIESEL expression or a file name) and the text style handle intoUnknownEntity.RText. A read failure only reports a warning and leavesRTextnull.If you prefer a dedicated
RTextentity instead of data onUnknownEntity, I can rework it.Tests
The full
ACadSharp.Testssuite passes on net9.0 (2432 passed, 2 skipped). I did not add tests: the writer does not produce RTEXT, so a synthetic DWG cannot be created for this path. It was checked against real drawings that I cannot share.🤖 Generated with Claude Code