Repository navigation
perf: replace slow_primes with primal - #84
Merged
Merged
Conversation
DoodlesEpic
added
enhancement
DoodlesEpic
marked this pull request as ready for review
September 21, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced deprecated
slow_primeswithprimal. Both use the Sieve of Eratosthenes. The command keeps its inclusive limit and existing response format.I added an independent trial-division test for every limit from 0 through 1,000 in a separate commit.
Validation: Rust tests, formatting, Clippy, four desktop builds, the Linux AppImage smoke test, CodeQL and performance checks passed. Local calculation benchmarks were 47–84% faster than the previous dev commit.
Part of #34. Algorithm selection remains for a later task.