Skip to content

fix(testing): update turbo task graph for test:e2e cache - #1808

Open
Abhinay-kal wants to merge 1 commit into
DouglasNeuroInformatics:mainfrom
Abhinay-kal:fix/issue-1766
Open

Abhinay-kal wants to merge 1 commit into
DouglasNeuroInformatics:mainfrom
Abhinay-kal:fix/issue-1766

Conversation

@Abhinay-kal

Copy link
Copy Markdown

Fixes #1766

Adds "cache": false to the test:e2e task in turbo.json to prevent stale cached test passes since the e2e test suite requires a live server and database.

Also updates the testing strategy documentation to reflect this change.

Add cache: false to test:e2e in turbo.json to prevent stale cached

test passes. Updates testing-strategy.md.
Copilot AI balanced review requested due to automatic review settings October 10, 2026 06:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gdevenyi gdevenyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The turbo.json change is correct, and a dry run confirms that test:e2e is now uncached.

The maintainers accept that local test:e2e runs are no longer cached.

There is one small change to make in .agents/docs/architecture/testing-strategy.md (lines 108-110). The new sentence is now between the first sentence and its parenthetical, (builditself depends on^buildanddb:generate), so the parenthetical seems to be about test:e2e. Please put the parenthetical back before the full stop of the first sentence. Then put the "cache": false sentence after "it is not fast.", or in a new paragraph.

If you hand this to Claude Code, Fable 5 is the right size. The PR changes build tooling, so it needs the strongest model even though the remaining edit is small.

Reviewed at commit ccb59d9.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pnpm test:e2e replays a cached pass after app code changes because the task hash covers only the testing package

3 participants