Repository navigation
fix(web): align remote assignment table colors with datahub subject table - #1811
Open
thomasbeaudry wants to merge 2 commits into
Open
thomasbeaudry wants to merge 2 commits into
thomasbeaudry wants to merge 2 commits into
Conversation
…able Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gdevenyi
requested changes
Oct 14, 2026
gdevenyi
left a comment
gdevenyi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. Two things are missing before this can merge:
The maintainers accept the page background for tables and inputs inside the wizard and delete cards, to match the datahub subject table.
- E2E test. Every change needs an end-to-end test in
testing/. Intesting/src/specs/remote-assignments-wizard.spec.ts, load a file with more than ten columns into the wizard. Then check that the column-mapping table (bulk-column-mapping) is no taller than 28rem (448px) and that it scrolls (scrollHeight > clientHeight). The spec already has aboundingBoxhelper for this type of layout check. - Unit tests. In
apps/web/src/components/BulkRemoteAssignmentWizard/__tests__/MapStep.test.tsx, check that the column-mapping table frame gets the height cap and the vertical scroll classes. InWizardTable.test.tsx, check that the frame keepsbg-backgroundwhen a caller passes its ownclassName.
If you hand this to Claude Code, Opus 5 is the right size — the tests span apps/web and the Playwright suite, and the e2e part must load a wide fixture file through the wizard.
Reviewed at commit 7fc352c.
Adds the tests the review asked for: - An e2e case loading a 24-column file through the wizard, asserting the mapping frame stays within its 28rem cap and scrolls inside itself. - A MapStep case pinning the cap and the vertical scroll on that frame. - A WizardTable case pinning `bg-background` against a caller's own class, since `cn` lets a later class win and inheriting the card surface is what made these tables read differently from the subject table. Both new cases were confirmed to fail with the cap removed. `bulk-column-mapping` moves onto the WizardTable frame, which is the element that actually scrolls; the wrapper around it holds the heading too, so its height is never the capped one. Nothing read the id before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rootStylecard-color overrides from create and delete remote assignment DataTables so their row colors match the datahub subject tablebg-backgroundto WizardTable, FileDropzone and TextArea in the bulk assignment wizard so they use the page background instead of inheriting the card surfacesize: 40, maxSize: 40) between create and delete assignment tables🤖 Generated with Claude Code