Repository navigation
fix(outreach): translate docs sidebar section labels into French - #1814
Open
Shaji-Mohammed wants to merge 2 commits into
Open
Shaji-Mohammed wants to merge 2 commits into
Shaji-Mohammed wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1793.
What changed
The French docs sidebar showed English group headings. Starlight sidebar entries now carry
translations: { fr: … }:astro.config.ts)translationsfield on the typedoc plugin's sidebar optionsIntroduction, Guides and Concepts are the same words in French. Pages in these sections stay English-only, per
docs/AGENTS.md.Why not the suggested fix
The issue suggests passing
translationsthroughgetSidebarGroupFromPackageReflections/getSidebarGroupFromReflections. Both functions call themselves recursively with the sameoptionsobject to build nested groups under their own labels (child.name). Readingoptions.translationsthere would give nested groups the top-level French label unless each call site added a condition. Instead, the translations are attached once ingetSidebarFromReflections, where the top-level group replaces the sidebar placeholder. That function already appliesbadgethere.Verification
pnpm lintgreen; outreachastro check0 errors, build succeeds.pnpm test:coveragegreen (384/384 files, 100%), run withNODE_OPTIONS=--no-experimental-webstoragebecause the local machine is on Node 25.Exceptions:
apps/outreachhas no test suite, by decision (apps/outreach/AGENTS.md). The build comparison above is the check.pnpm test:e2enot run locally (Playwright browsers not installed). The e2e suite doesn't cover the outreach site, so CI's run covers it.