Repository navigation
fix(web): preserve instrument showcase tag options - #1816
Open
misaelalves99 wants to merge 1 commit into
Open
misaelalves99 wants to merge 1 commit into
misaelalves99 wants to merge 1 commit into
Conversation
misaelalves99
marked this pull request as ready for review
October 16, 2026 15:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Instrument Showcase Tags filter could lose options after a parent re-rendered while a search was active. Its tag options were derived from
filteredInstruments, causing tags outside the narrowed results to disappear.This change:
availableInstrumentscollection usinguseMemo, removing redundant state and effect logic.Fixes #1692.
Validation
Testing limitations
The Playwright runs used an isolated setup with reduced demo-data generation to avoid an initialization timeout under WSL2. The complete monorepo E2E suite was not executed.
The full
pnpm lintworkflow was not run because it performs automatic modifications; relevant TypeScript, ESLint and Prettier checks were performed separately without modifying files.Ready for review. GitHub CI checks have passed; awaiting code owner review.