Skip to content

fix(playground): search instruments by label #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
misaelalves99 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(playground): search instruments by label #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/playground/src/components/Header/InstrumentSelector/InstrumentSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export const InstrumentSelector = () => {
{instruments.map((instrument) => (
<Command.Item
key={instrument.id}
keywords={[instrument.label]}
value={instrument.id}
onSelect={(id) => {
setSelectedInstrument(id);
Expand Down
6 changes: 2 additions & 4 deletions testing/src/pages/playground/index.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,10 @@ export class PlaygroundPage {
await this.$ref.goto(url);
}

/**
* Picks an example or template from the header's instrument list by its label. The list's search
* box matches on instrument ids rather than labels, so the option is clicked without filtering.
*/
/** Picks an example or template from the header's instrument list by its label. */
async selectInstrument(label: string): Promise<void> {
await this.$ref.getByRole('combobox', { name: 'Load an instrument...' }).click();
await this.$ref.getByPlaceholder('Search...').fill(label);
await this.$ref.getByRole('option', { exact: true, name: label }).click();
}
}
9 changes: 9 additions & 0 deletions testing/src/specs/playground.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,15 @@ test.describe('playground', () => {
test.describe.configure({ mode: 'default' });
test.slow();

test('should find an instrument by its visible label in the selector', async ({ page }) => {
const playground = new PlaygroundPage(page);
await playground.goto();

await page.getByRole('combobox', { name: 'Load an instrument...' }).click();
await page.getByPlaceholder('Search...').fill('Form Reference');
await expect(page.getByRole('option', { exact: true, name: 'Form Reference' })).toBeVisible();
});

test('should run the preview on an origin other than the editor and render the instrument there @smoke', async ({
page
}) => {
Expand Down
Loading