Skip to content

fix(web): stop the record array upload parser truncating values #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(web): stop the record array upload parser truncating values #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aaa111
fix(web): reject a record array cell that is missing its closing pare…
SAY-5 Oct 18, 2026
2ffc557
fix(web): split each record array field on its first colon only
SAY-5 Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions apps/web/src/utils/__tests__/upload.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,19 @@ describe('Zod3', () => {
it('should leave out a field the record does not mention', async () => {
await expect(processItems('RECORD_ARRAY(name:item1)')).resolves.toMatchObject([{ items: [{ name: 'item1' }] }]);
});

it('should reject a record array missing its closing parenthesis, rather than dropping its last character', async () => {
await expectRejection(
processItems('RECORD_ARRAY(name:item1,quantity:12'),
"Syntax error in RECORD_ARRAY declaration: RECORD_ARRAY(name:item1,quantity:12 at column name: 'items' and row number '1'"
);
});

it('should keep a colon inside a record array value, splitting each field on its first colon only', async () => {
await expect(processItems('RECORD_ARRAY(name:10:30,quantity:1;)')).resolves.toMatchObject([
{ items: [{ name: '10:30', quantity: 1 }] }
]);
});
});
});
});
Expand Down
10 changes: 6 additions & 4 deletions apps/web/src/utils/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function extractRecordArrayEntry(entry: string): { [key: string]: string }[] {
entry = entry.trim();
const opening = 'RECORD_ARRAY(';
const closing = ')';
if (!entry.startsWith(opening) && !entry.endsWith(closing)) {
if (!entry.startsWith(opening) || !entry.endsWith(closing)) {
throw new UploadError({
en: `Syntax error in RECORD_ARRAY declaration: ${entry}`,
fr: `Erreur de syntaxe dans la déclaration RECORD_ARRAY : ${entry}`
Expand All @@ -165,15 +165,17 @@ function extractRecordArrayEntry(entry: string): { [key: string]: string }[] {
}
const records: { [key: string]: string } = {};
recordsList.forEach((rawRecord, i) => {
const [recordKey, recordValue] = rawRecord.split(':').map((s) => s.trim());
if (!recordKey) {
const separatorIndex = rawRecord.indexOf(':');
const recordKey = rawRecord.slice(0, separatorIndex).trim();
const recordValue = rawRecord.slice(separatorIndex + 1).trim();
if (separatorIndex === -1 || !recordKey) {
throw new UploadError({
en: `Malformed record at index ${i}`,
fr: `Enregistrement mal formé à l'index ${i}`
});
}
//recordValue can be empty if the value is optional
records[recordKey] = recordValue!;
records[recordKey] = recordValue;
});
return records;
});
Expand Down