Repository navigation
Render DateTimeField from Form with variant: 'datetime' - #125
Merged
joshunrau merged 3 commits intoOct 7, 2026
Merged
Conversation
joshunrau
approved these changes
Oct 7, 2026
|
🎉 This PR is included in version 6.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render
DateTimeFieldfromFormwithvariant: 'datetime'The
DateTimeFieldcomponent already exists, butFormhad no way to render it. This PR lets adatefield opt into date + time input by settingvariant: 'datetime'. Either way, the form stores a singleDate.Changes
@douglasneuroinformatics/libui-form-typesfrom^1.4.0to^1.5.0. That version adds the optionalvariant?: 'date' | 'datetime'to date fields, defaulting to'date'.ScalarField: forkind: 'date', rendersDateTimeFieldwhenvariant === 'datetime'andDateFieldotherwise, so existing date fields are unaffected.DateTimeField: props now come fromDateFormField(minuskindandvariant) instead ofBaseFormField, so they match the form field type.Formstory gains adateTimefield ("Date and Time"), andWithInitialValuessets it.Form.test.tsxgains two tests:variant: 'datetime'renders the date button and time input, not the date-only input.Notes for reviewers
timeFormat="24h"(the segmented 24-hour time input) isn't in the form field type, so fields rendered throughFormalways use the native time input, which follows the browser locale. Supporting 24h there would need a matching option inlibui-form-types.Testing
tscpassesvitest run: 217/217 tests pass🤖 Generated with Claude Code
Closes issue #122