Repository navigation
Conversation
Owner
|
Нужны тесты для контейнеров. |
Dovgalyuk
requested changes
Oct 29, 2026
|
|
||
| class VMStack { | ||
| Stack data; | ||
| vector<bool> flags; |
Owner
There was a problem hiding this comment.
А нельзя просто взять такой же стек, как для данных?
|
|
||
| struct Instruction { | ||
| string command; | ||
| vector<string> args; |
Owner
There was a problem hiding this comment.
У команды может быть больше одного аргумента?
| data.push(b); | ||
| } | ||
|
|
||
| vector<Value> values() const { |
| add_vm_test(variables variables.txt variables.out) | ||
| add_vm_test(swap swap.txt swap.out) | ||
| add_vm_test(error_return error_return.txt error.out) | ||
| add_vm_test(error_address_pop error_address_pop.txt error.out) |
Owner
There was a problem hiding this comment.
Не проверяется код возврата или вывод сообщения об ошибке.
Dovgalyuk
reviewed
Oct 30, 2026
| if (empty()) throw runtime_error("Stack is empty"); | ||
| return { data.get(), flags[0] }; | ||
|
|
||
| Stack flags_copy = flags; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Реализованы команды и операции стека для лабораторной работы № 2.
Выполнены модули односвязного списка и стека.
Обновлена конфигурация CMake для сборки проекта.
Проверена работа программы на примерах и сценариях с ошибками.