Repository navigation
fix(security): harden the CSV formula guard against leading whitespace - #52
Merged
Merged
Conversation
Shared\Domain\CsvFormulaGuard now also neutralises cells that begin with a tab, carriage return or newline (OWASP CSV-injection guidance), on top of the existing = + - @ formula leads. A spreadsheet can otherwise glue such a cell to its neighbour and reinterpret it. Both dashboard CSV exports (Recettes, Journal d'activité) benefit automatically. Behaviour change limited to those leading-whitespace inputs, which are now prefixed with a quote to force plain text. Gates green: CS-Fixer, PHPStan (max), PHPUnit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens
Shared\Domain\CsvFormulaGuard: cells starting with a tab, CR or newline are now neutralised too (OWASP CSV-injection guidance), in addition to= + - @. Both dashboard CSV exports benefit automatically. Behaviour change is limited to those leading-whitespace inputs (now prefixed with a quote). Tests updated.