Repository navigation
refactor(shop): rename PilotageSchemaManager to ShopSchemaManager - #55
Merged
Merged
Conversation
Aligns the class name with its bounded context: it manages the Shop context's tables, and the "Pilotage" prefix predated the Pilotage -> Shop context rename. Pure rename, no behaviour change. The stored option key `luziapi_pilotage_receipts_schema_version` is deliberately left unchanged (it is data, not code — renaming it would trigger a one-time re-migration in production). The dashboard-feature names (PilotageController, PilotageTabs, the admin/pilotage/ views, admin-pilotage.js) keep "Pilotage" on purpose: there it is the UI name of the dashboard (« tableau de pilotage »), not the bounded context — renaming them to "Shop" would be less clear. Gates green: CS-Fixer, PHPStan (max), PHPUnit (348), e2e (schema, perf, receipt).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the class name with its bounded context (it manages the Shop tables; the
Pilotageprefix predated the Pilotage→Shop rename). The stored option keyluziapi_pilotage_receipts_schema_versionis kept unchanged (data, not code — renaming it would force a one-time re-migration in prod). Pure rename, no behaviour change.The dashboard-feature names (
PilotageController,PilotageTabs,admin/pilotage/views,admin-pilotage.js) keep "Pilotage" on purpose — there it is the UI name of the dashboard, not the context.