Repository navigation
fix(ci): avoid signing metadata pipe failures - #58
Merged
Merged
Conversation
Signed-off-by: Marc Went <marc@went.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the remaining current-main CI failure: quiet grep can close its input before printf finishes, so pipefail rejects valid signing metadata. Feed the same team, Developer ID authority, timestamp and hardened-runtime checks with Bash here-strings.
#57's final-head CI passed all 20 jobs. Its tree equals main at
367836835eeb419fc3d523ebb9231c17690ee334. Main run 41105282352 subsequently passed every runtime partition, both native jobs and universal packaging, but failed ARM tooling shard 2 withprintf: write error: Broken pipeinTestMacOSResumeRetainsExactArtifactsAndIDsAcrossAttempts. This follow-up repairs that separate failure. The historical Intel core timeout needs no additional timeout or coverage change.Evidence
After: both valid cases pass; all four missing-field cases fail. Existing wrong-Intel-team, timestamp/runtime, artifact custody and publication-refusal tests remain passing.
bc457b5b158f38763c11c3a5bb62627352ab2b5a, treed0f6f9f0b1cf9cf37945a0133fdc152a67d6487c, full diff SHA-25683b537ebec9bd64e7532286a5da4271cf605fb0e114c30c530e50b97ef32a889. Independently passed 16 focused tooling race tests, 30 startup/ownership tests across three packages, static/policy checks and an isolated base/candidate contrast.bc457b5b158f38763c11c3a5bb62627352ab2b5a: all 20 effective checks pass, includingci-required. Attempt 1 had a post-SIGKILL cold authentication timeout in Intel HTTPS. The unchanged complete lifecycle race test passed locally, then the targeted same-head Intel HTTPS retry and dependent aggregate passed. No source, deadline, bcrypt, race or coverage change was made for that retry. Cold race-instrumented bcrypt remains a leading explanation, not a proven hosted cause.Reproduction and continuation details: CI signature verification handoff.
Merge Danger
Door: two-way, a narrow shell-input change with no state migration.
Blast Radius: signing metadata verification. Matching predicates, per-slice codesign verification, timeouts, required matrices, ownership checks and release gates are preserved. Real Service Management, installed-app/Intel acceptance, Developer ID signing and Apple acceptance remain separate gates. No merge, release, fresh Apple submission or deployment is included.