Skip to content

FCT tendency tests swallow failures; FCTHNewInv is inf #573

Closed

Description

@xylar

The FCT checks in TendencyTermsTest (added in #447) can never fail CTest, and several of them are failing silently.

  • testFCTTracerHorzAdvOnCell sets Err = 0; after each check, so it always returns 0 and failures only appear as [error] lines in the test log.
  • FCTHNewInv is inf on the plane, single-precision plane and sphere meshes.
  • In TEND_PLANE_SINGLE_PRECISION_TEST, FCTHProv, FCTHProvInv, FCTHighAndLowOrderFlux_High and FCTAccumulateHighOrderFlux_0 also fail (e.g. FCTHProv expected 0, got 1.5e-05).

Seen on chrysalis/intel with develop at 480467b; grep FCT test/logs/TEND_*.log in a build tree shows them.

@overfelt, could you take a look?

Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly.

Activity

  1. overfelt commented on Sep 23, 2026

    @overfelt

    I'll look into this.

  2. added a commit that references this issue on Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions