Skip to content

Disable floating point contractions on GPU architectures #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewdnolan wants to merge 2 commits into
base: develop
Choose a base branch
from
+20 −0
Open

Disable floating point contractions on GPU architectures #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
533e57a
Disable floating point contractions on GPU archs
andrewdnolan Oct 1, 2026
63fc21e
Add OMEGA_DISABLE_FP_CONTRACT CMake option
grnydawn Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/omega/OmegaBuild.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ macro(common)
option(OMEGA_LOG_FLUSH "Turn on unbuffered logging (default OFF)." OFF)
option(OMEGA_TEST_CDASH "Turn on CDash support (default ON)." ON)
option(OMEGA_EXTERNAL_PROF "Integration of Omega timers with external profiling tools (default OFF)." OFF)
option(OMEGA_DISABLE_FP_CONTRACT "Disable floating point contraction on GPU architectures (default ON)." ON)

if("${OMEGA_BUILD_TYPE}" STREQUAL "Debug" OR "${OMEGA_BUILD_TYPE}" STREQUAL "DEBUG")
set(OMEGA_DEBUG ON)
Expand Down
19 changes: 19 additions & 0 deletions components/omega/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,25 @@ target_compile_definitions(
OMEGA_VECTOR_LENGTH=${OMEGA_VECTOR_LENGTH}
)

# Disable floating point contraction (e.g. fused multiply-add) for GPU
# architectures. Needed for ERS and PEM test to pass COMPARE step.
# Controlled by OMEGA_DISABLE_FP_CONTRACT (default ON)
if (OMEGA_DISABLE_FP_CONTRACT)
if (OMEGA_ARCH STREQUAL "CUDA")
target_compile_options(OmegaLibFlags INTERFACE
$<$<COMPILE_LANGUAGE:CXX>:--fmad=false -Xcompiler -ffp-contract=off>
)
elseif (OMEGA_ARCH STREQUAL "HIP")
target_compile_options(OmegaLibFlags INTERFACE
$<$<COMPILE_LANGUAGE:CXX>:-ffp-contract=off>
)
elseif (OMEGA_ARCH STREQUAL "SYCL")
target_compile_options(OmegaLibFlags INTERFACE
$<$<COMPILE_LANGUAGE:CXX>:-fp-model=precise -ffp-contract=off>
)
endif()
endif()

if(OMEGA_SINGLE_PRECISION)
target_compile_definitions(
OmegaLibFlags
Expand Down
Loading