Skip to content

Compute Brunt-Vaisala frequency using mid-layer pressure in VertMix - #616

Merged
sbrus89 merged 1 commit into
E3SM-Project:developfrom
mwarusz:omega/vmix-pressure-fix
Oct 26, 2026
Merged

Compute Brunt-Vaisala frequency using mid-layer pressure in VertMix#616
sbrus89 merged 1 commit into
E3SM-Project:developfrom
mwarusz:omega/vmix-pressure-fix

Conversation

@mwarusz

@mwarusz mwarusz commented Oct 19, 2026 •
edited by andrewdnolan
Loading

Copy link
Copy Markdown
Member

computeBruntVaisalaFreqSq expects mid-layer pressure, but the call to this function in vertical mixing used interface pressure. Fixes #614.

Checklist

  • Linting

  • Building

    • CMake build does not produce any new warnings from changes in this PR

  • Testing

    aurora, intel, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    aurora, intelgpu, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    chrysalis, intel, openmpi

    • CTests Pass
    • Polaris omega_pr Pass
    • ERS_Ld5.T62_oQU240.GOMEGA-IAF
    • SMS_Ld3.ne4pg2_oQU240.WCYCL1850NS-OMEGA

    frontier, craygnu, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    frontier, craygnu-mphipcc, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    pm-cpu, gnu, mpich

    • CTests Pass
    • Polaris omega_pr Pass

    pm-gpu, gnugpu, mpich

    • CTests Pass
    • Polaris omega_pr Pass

  • Provide relevant details in a comment to the PR titled Testing with the following:

    • Which machines CTest unit tests
      have been run on and indicate that are all passing.
    • The Polaris omega_pr test suite
      has passed, using the Polaris e3sm_submodules/Omega baseline
    • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
    • Indicate "All tests passed" or document failing tests
    • Document testing used to verify the changes including any tests that are added/modified/impacted.

@mwarusz

mwarusz commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

Testing on frontier

CTests

All tests passed with

  • craygnu
  • craygnu-mphipcc

Polaris omega_pr suite with craygnu

  • Baseline workdir: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/../math/baseline-craygnu
  • Baseline build: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/math/baseline-craygnu/ocean_build
  • PR build: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/build-craygnu
  • PR workdir: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/pr-craygnu
  • Baseline Omega: cdb935bb5a8d995b0878616e001a2701a2627519 (Omega-v0.1.0-alpha.1-6142-gcdb935bb5a)
  • PR Omega: d98a5da59fb03aa4de49826e19415f66e4f08021 (omega-v0.0.0-alpha0.1-26102-gd98a5da59f) (at setup, not build)
  • Machine: frontier
  • Partition: batch
  • Compiler: craygnu
  • Build type: Release
  • Log: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/pr-craygnu/polaris_omega_pr.o5712651
  • Result:
    • Diffs (3 of 32):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_4_del4
      - normalVelocity:    l1=3.791e-01  l2=4.443e-02  linf=1.030e-02
      - temperature:       l1=1.304e-02  l2=3.593e-03  linf=1.833e-03
      - salinity:          l1=7.650e-11  l2=8.031e-13  linf=2.132e-14
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=3.776e-07  l2=5.502e-08  linf=2.292e-08
      - salinity:          l1=2.970e-12  l2=1.501e-13  linf=1.421e-14
      - temperature:       l1=1.263e-12  l2=5.839e-14  linf=7.105e-15
    - ocean/column/kpp_combined
      - normalVelocity:    l1=2.994e-02  l2=2.001e-03  linf=3.338e-04
      - vertViscTopOfCell: l1=1.792e-02  l2=1.675e-03  linf=2.048e-04
      - vertDiffTopOfCell: l1=1.796e-02  l2=1.677e-03  linf=2.046e-04
      - temperature:       l1=7.036e-03  l2=9.315e-04  linf=1.725e-04
      - salinity:          l1=1.898e-04  l2=2.144e-05  linf=4.069e-06
      - layerThickness:    l1=5.459e-06  l2=7.764e-07  linf=1.468e-07
Recent commits

Baseline Omega:

cdb935bb5a Merge pull request #600 from xylar/omega/fix-pm-mpi-flags
b90c3dae8d Merge pull request #601 from andrewdnolan/omega/cxx20-for-coupled
9641c6cf9e Merge pull request #546 from xylar/omega/fix-cf-units
55c3de8c15 Merge pull request #566: e3sm/master into omega/develop
9aba4a8032 Merge pull request #597 from xylar/omega/fix-real-literal-nvcc

PR Omega:

d98a5da59f Compute Brunt-Vaisala frequency using mid-layer pressure in VertMix
260d05971a Work
9656466bb6 Merge PR #570 into develop, resolving Tendencies.cpp initializer order
d1d3ea6506 Merge pull request #466 from alicebarthel/omega/add-frazil-basic-rebased
cdb935bb5a Merge pull request #600 from xylar/omega/fix-pm-mpi-flags

Polaris omega_pr suite with craygnu-mphipcc

  • Baseline workdir: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/../math/baseline-craygnu-mphipcc/
  • Baseline build: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/math/baseline-craygnu-mphipcc/ocean_build
  • PR build: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/build-craygnu-mphipcc
  • PR workdir: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/pr-craygnu-mphipcc
  • Baseline Omega: cdb935bb5a8d995b0878616e001a2701a2627519 (Omega-v0.1.0-alpha.1-6142-gcdb935bb5a)
  • PR Omega: d98a5da59fb03aa4de49826e19415f66e4f08021 (omega-v0.0.0-alpha0.1-26102-gd98a5da59f) (at setup, not build)
  • Machine: frontier
  • Partition: batch
  • Compiler: craygnu-mphipcc
  • Build type: Release
  • Log: /lustre/orion/cli115/scratch/mwaruszewski/omega-pr-testing/vmix-pressure-fix/pr-craygnu-mphipcc/polaris_omega_pr.o5712841
  • Result:
    • Diffs (2 of 32):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=1.752e-01  l2=5.109e-03  linf=8.424e-04
      - temperature:       l1=2.351e-07  l2=9.557e-09  linf=1.149e-09
      - salinity:          l1=6.769e-10  l2=3.086e-12  linf=5.684e-14
    - ocean/column/kpp_combined
      - normalVelocity:    l1=3.010e-02  l2=2.013e-03  linf=3.364e-04
      - vertViscTopOfCell: l1=1.764e-02  l2=1.654e-03  linf=2.040e-04
      - vertDiffTopOfCell: l1=1.767e-02  l2=1.657e-03  linf=2.038e-04
      - temperature:       l1=7.037e-03  l2=9.321e-04  linf=1.750e-04
      - salinity:          l1=1.884e-04  l2=2.117e-05  linf=4.020e-06
      - layerThickness:    l1=5.478e-06  l2=7.764e-07  linf=1.486e-07
Recent commits

Baseline Omega:

cdb935bb5a Merge pull request #600 from xylar/omega/fix-pm-mpi-flags
b90c3dae8d Merge pull request #601 from andrewdnolan/omega/cxx20-for-coupled
9641c6cf9e Merge pull request #546 from xylar/omega/fix-cf-units
55c3de8c15 Merge pull request #566: e3sm/master into omega/develop
9aba4a8032 Merge pull request #597 from xylar/omega/fix-real-literal-nvcc

PR Omega:

d98a5da59f Compute Brunt-Vaisala frequency using mid-layer pressure in VertMix
260d05971a Work
9656466bb6 Merge PR #570 into develop, resolving Tendencies.cpp initializer order
d1d3ea6506 Merge pull request #466 from alicebarthel/omega/add-frazil-basic-rebased
cdb935bb5a Merge pull request #600 from xylar/omega/fix-pm-mpi-flags

@mwarusz

mwarusz commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@hyungyukang Would you mind reviewing this PR ?

@mwarusz
mwarusz requested a review from hyungyukang October 19, 2026 23:23
@hyungyukang

hyungyukang commented Oct 20, 2026

Copy link
Copy Markdown

@mwarusz , sure, I can review this PR.

hyungyukang
hyungyukang approved these changes Oct 20, 2026
View reviewed changes

@hyungyukang hyungyukang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mwarusz, for this bug-fix PR. The pressure used in the call should be the layer-centered value rather than the interface value, and this PR corrects that issue.

I tested this PR by running the realistic global ocean case on the RRS18to6v3 mesh for one day, and the run completed successfully.

  • Kinetic energy cell at day 1
Image

I’m approving this PR based on @mwarusz’s tests above, my own testing, and visual inspection. Thanks @mwarusz !

@vanroekel vanroekel added this to the 1st E3SM Merge milestone Oct 24, 2026
sbrus89 added a commit to sbrus89/E3SM that referenced this pull request Oct 26, 2026
@sbrus89
Add the manifest for testing E3SM-Project#616
df95fe0 
Temporary.  Testers build the parent of this commit.
@sbrus89

sbrus89 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Testing on chrysalis

Tested the merge of #616 (130f2c4df7) into develop (695f548841) as d4a747c70a, against Polaris' Omega submodule (23b13afac5).

Row CTests omega_pr New build warnings
chrysalis, intel, openmpi 61 of 61 passed 30 of 34 passed, 4 with baseline differences 0
chrysalis, intel, openmpi

Polaris omega_pr suite

  • Baseline workdir: /lcrc/group/e3sm/sbrus/omega_pr_test/baselines/chrysalis_intel_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /lcrc/group/e3sm/sbrus/omega_pr_test/baselines/chrysalis_intel_polaris-335cc49_omega-23b13af/build
  • PR build: /lcrc/group/e3sm/sbrus/omega_pr_test/pr616-130f2c4/chrysalis_intel/build
  • PR workdir: /lcrc/group/e3sm/sbrus/omega_pr_test/pr616-130f2c4/chrysalis_intel/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.1.0-452-g335cc496de-dirty)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: chrysalis
  • Partition: debug
  • Compiler: intel
  • Build type: Release
  • Log: /lcrc/group/e3sm/sbrus/omega_pr_test/pr616-130f2c4/chrysalis_intel/omega_pr/polaris_omega_pr.o1316020
  • Result:
    • Diffs (4 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=5.321e-02  l2=2.835e-03  linf=7.389e-04
      - temperature:       l1=1.006e-10  l2=1.947e-12  linf=3.801e-13
      - salinity:          l1=1.231e-10  l2=1.024e-12  linf=3.553e-14
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.075e+01  l2=1.853e+00  linf=8.590e-01
      - salinity:          l1=3.067e+00  l2=3.391e-01  linf=2.116e-01
      - normalVelocity:    l1=1.633e+01  l2=1.875e-01  linf=1.222e-01
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.086e+01  l2=1.797e+00  linf=1.088e+00
      - salinity:          l1=2.961e+00  l2=2.455e-01  linf=1.063e-01
      - normalVelocity:    l1=1.526e+01  l2=1.235e-01  linf=5.219e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=2.994e-02  l2=2.001e-03  linf=3.338e-04
      - vertViscTopOfCell: l1=1.792e-02  l2=1.675e-03  linf=2.048e-04
      - vertDiffTopOfCell: l1=1.796e-02  l2=1.677e-03  linf=2.046e-04
      - temperature:       l1=7.036e-03  l2=9.315e-04  linf=1.725e-04
      - salinity:          l1=1.898e-04  l2=2.144e-05  linf=4.069e-06
      - layerThickness:    l1=5.459e-06  l2=7.764e-07  linf=1.468e-07
Recent commits

Polaris:

335cc496de Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a3 Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7a Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a5 Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cfc Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: chrysalis
  • Compiler: intel
  • Build type: Release
  • Build: /lcrc/group/e3sm/sbrus/omega_pr_test/pr616-130f2c4/chrysalis_intel/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /lcrc/group/e3sm/sbrus/omega_pr_test/pr616-130f2c4/chrysalis_intel/build/ctests.log

Build warnings

No new warnings (37 in the PR build, 37 in the baseline build).

  • Baseline build log: /lcrc/group/e3sm/sbrus/omega_pr_test/baselines/chrysalis_intel_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /lcrc/group/e3sm/sbrus/omega_pr_test/pr616-130f2c4/chrysalis_intel/build/build_omega.log

Notes

The 4 baseline differences (kpp_combined, the two qu240 cached_forward tasks and the overflow smoke test) are expected from this PR. It changes the pressure passed to the Brunt-Vaisala frequency in VertMix, which feeds vertical viscosity and diffusivity, and the only other commit on develop since the baseline (#622) changes machine config and docs only.

@sbrus89

sbrus89 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Testing on frontier

Tested the merge of #616 (130f2c4df7) into develop (695f548841) as d4a747c70a, against Polaris' Omega submodule (23b13afac5).

Row CTests omega_pr New build warnings
frontier, craygnu, mpich 61 of 61 passed 29 of 34 passed, 5 with baseline differences 0
frontier, craygnu-mphipcc, mpich 61 of 61 passed 30 of 34 passed, 4 with baseline differences 0
frontier, craygnu, mpich

Polaris omega_pr suite

  • Baseline workdir: /ccs/home/brus/run/omega_pr_test/baselines/frontier_craygnu_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /ccs/home/brus/run/omega_pr_test/baselines/frontier_craygnu_polaris-335cc49_omega-23b13af/build
  • PR build: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu/build
  • PR workdir: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.1.0-452-g335cc496de)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: frontier
  • Partition: batch
  • Compiler: craygnu
  • Build type: Release
  • Log: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu/omega_pr/polaris_omega_pr.o5767854
  • Result:
    • Diffs (5 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_4_del4
      - normalVelocity:    l1=3.791e-01  l2=4.443e-02  linf=1.030e-02
      - temperature:       l1=1.304e-02  l2=3.593e-03  linf=1.833e-03
      - salinity:          l1=7.650e-11  l2=8.031e-13  linf=2.132e-14
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=3.776e-07  l2=5.502e-08  linf=2.292e-08
      - salinity:          l1=2.970e-12  l2=1.501e-13  linf=1.421e-14
      - temperature:       l1=1.263e-12  l2=5.839e-14  linf=7.105e-15
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.075e+01  l2=1.853e+00  linf=8.590e-01
      - salinity:          l1=3.067e+00  l2=3.391e-01  linf=2.116e-01
      - normalVelocity:    l1=1.633e+01  l2=1.875e-01  linf=1.222e-01
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.086e+01  l2=1.797e+00  linf=1.088e+00
      - salinity:          l1=2.961e+00  l2=2.455e-01  linf=1.063e-01
      - normalVelocity:    l1=1.526e+01  l2=1.235e-01  linf=5.219e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=2.994e-02  l2=2.001e-03  linf=3.338e-04
      - vertViscTopOfCell: l1=1.792e-02  l2=1.675e-03  linf=2.048e-04
      - vertDiffTopOfCell: l1=1.796e-02  l2=1.677e-03  linf=2.046e-04
      - temperature:       l1=7.036e-03  l2=9.315e-04  linf=1.725e-04
      - salinity:          l1=1.898e-04  l2=2.144e-05  linf=4.069e-06
      - layerThickness:    l1=5.459e-06  l2=7.764e-07  linf=1.468e-07
Recent commits

Polaris:

335cc496de Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a3 Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7a Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a5 Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cfc Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: frontier
  • Compiler: craygnu
  • Build type: Release
  • Build: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu/build/ctests.log

Build warnings

No new warnings (3 in the PR build, 3 in the baseline build).

  • Baseline build log: /ccs/home/brus/run/omega_pr_test/baselines/frontier_craygnu_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu/build/build_omega.log
frontier, craygnu-mphipcc, mpich

Polaris omega_pr suite

  • Baseline workdir: /ccs/home/brus/run/omega_pr_test/baselines/frontier_craygnu-mphipcc_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /ccs/home/brus/run/omega_pr_test/baselines/frontier_craygnu-mphipcc_polaris-335cc49_omega-23b13af/build
  • PR build: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu-mphipcc/build
  • PR workdir: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu-mphipcc/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.1.0-452-g335cc496de)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: frontier
  • Partition: batch
  • Compiler: craygnu-mphipcc
  • Build type: Release
  • Log: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu-mphipcc/omega_pr/polaris_omega_pr.o5767954
  • Result:
    • Diffs (4 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=1.752e-01  l2=5.109e-03  linf=8.424e-04
      - temperature:       l1=2.351e-07  l2=9.557e-09  linf=1.149e-09
      - salinity:          l1=6.769e-10  l2=3.086e-12  linf=5.684e-14
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.159e+01  l2=1.907e+00  linf=8.647e-01
      - salinity:          l1=3.700e+00  l2=4.494e-01  linf=2.407e-01
      - normalVelocity:    l1=1.623e+01  l2=1.591e-01  linf=6.766e-02
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.216e+01  l2=2.008e+00  linf=1.088e+00
      - salinity:          l1=3.091e+00  l2=2.534e-01  linf=1.063e-01
      - normalVelocity:    l1=1.877e+01  l2=1.834e-01  linf=8.755e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=3.010e-02  l2=2.013e-03  linf=3.364e-04
      - vertViscTopOfCell: l1=1.764e-02  l2=1.654e-03  linf=2.040e-04
      - vertDiffTopOfCell: l1=1.767e-02  l2=1.657e-03  linf=2.038e-04
      - temperature:       l1=7.037e-03  l2=9.321e-04  linf=1.750e-04
      - salinity:          l1=1.884e-04  l2=2.117e-05  linf=4.020e-06
      - layerThickness:    l1=5.478e-06  l2=7.764e-07  linf=1.486e-07
Recent commits

Polaris:

335cc496de Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a3 Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7a Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a5 Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cfc Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: frontier
  • Compiler: craygnu-mphipcc
  • Build type: Release
  • Build: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu-mphipcc/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu-mphipcc/build/ctests.log

Build warnings

No new warnings (6 in the PR build, 6 in the baseline build).

  • Baseline build log: /ccs/home/brus/run/omega_pr_test/baselines/frontier_craygnu-mphipcc_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /ccs/home/brus/run/omega_pr_test/pr616-130f2c4/frontier_craygnu-mphipcc/build/build_omega.log

Notes

The tasks that differ from the baseline all ran to completion; only their baseline comparison failed. They are vertical-mixing tasks (KPP, nonlinear overflow and the QU240 realistic global cases), consistent with this PR changing how VertMix computes the Brunt-Vaisala frequency, so the differences look like the expected answer change. The only change merged into develop since the baseline Omega edits the Chrysalis CIME config, which cannot affect these results. On craygnu-mphipcc, overflow/nonlinear/pstar/smoke_test_horiz_adv_order_4_del4 matched the baseline, whereas on craygnu it differed.

@andrewdnolan

andrewdnolan commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Testing on chrysalis with intel compiler

Test were run with a local merge of this branch into develop at 695f548841.

  • ERS_Ld5.T62_oQU240.GOMEGA-IAF.chrysalis_intel.20261026_140649: PASS
  • SMS_Ld3.ne4pg2_oQU240.WCYCL1850NS-OMEGA.chrysalis_intel.20261026_140654: PASS

@sbrus89

sbrus89 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Testing on aurora

Tested the merge of #616 (130f2c4df7) into develop (695f548841) as d4a747c70a, against Polaris' Omega submodule (23b13afac5).

Row CTests omega_pr New build warnings
aurora, intel, mpich 61 of 61 passed 30 of 34 passed, 4 with baseline differences 0
aurora, intelgpu, mpich 61 of 61 passed 29 of 34 passed, 5 with baseline differences 0
aurora, intel, mpich

Polaris omega_pr suite

  • Baseline workdir: /home/brus/run/omega_pr_test/baselines/aurora_intel_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /home/brus/run/omega_pr_test/baselines/aurora_intel_polaris-335cc49_omega-23b13af/build
  • PR build: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intel/build
  • PR workdir: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intel/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.1.0-452-g335cc496d-dirty)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: aurora
  • Compiler: intel
  • Build type: Release
  • Log: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intel/omega_pr/polaris_omega_pr.o8968052
  • Result:
    • Diffs (4 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=5.321e-02  l2=2.835e-03  linf=7.389e-04
      - temperature:       l1=1.006e-10  l2=1.947e-12  linf=3.801e-13
      - salinity:          l1=1.231e-10  l2=1.024e-12  linf=3.553e-14
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.075e+01  l2=1.853e+00  linf=8.590e-01
      - salinity:          l1=3.067e+00  l2=3.391e-01  linf=2.116e-01
      - normalVelocity:    l1=1.633e+01  l2=1.875e-01  linf=1.222e-01
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.086e+01  l2=1.797e+00  linf=1.088e+00
      - salinity:          l1=2.961e+00  l2=2.455e-01  linf=1.063e-01
      - normalVelocity:    l1=1.526e+01  l2=1.235e-01  linf=5.219e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=2.994e-02  l2=2.001e-03  linf=3.338e-04
      - vertViscTopOfCell: l1=1.792e-02  l2=1.675e-03  linf=2.048e-04
      - vertDiffTopOfCell: l1=1.796e-02  l2=1.677e-03  linf=2.046e-04
      - temperature:       l1=7.036e-03  l2=9.315e-04  linf=1.725e-04
      - salinity:          l1=1.898e-04  l2=2.144e-05  linf=4.069e-06
      - layerThickness:    l1=5.459e-06  l2=7.764e-07  linf=1.468e-07
Recent commits

Polaris:

335cc496d Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7 Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cf Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: aurora
  • Compiler: intel
  • Build type: Release
  • Build: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intel/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intel/build/ctests.log

Build warnings

No new warnings (14 in the PR build, 14 in the baseline build).

  • Baseline build log: /home/brus/run/omega_pr_test/baselines/aurora_intel_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intel/build/build_omega.log
aurora, intelgpu, mpich

Polaris omega_pr suite

  • Baseline workdir: /home/brus/run/omega_pr_test/baselines/aurora_intelgpu_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /home/brus/run/omega_pr_test/baselines/aurora_intelgpu_polaris-335cc49_omega-23b13af/build
  • PR build: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intelgpu/build
  • PR workdir: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intelgpu/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.1.0-452-g335cc496d-dirty)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: aurora
  • Compiler: intelgpu
  • Build type: Release
  • Log: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intelgpu/omega_pr/polaris_omega_pr.o8968258
  • Result:
    • Diffs (5 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_4_del4
      - normalVelocity:    l1=4.335e-01  l2=5.453e-02  linf=2.270e-02
      - temperature:       l1=3.741e-02  l2=6.604e-03  linf=1.899e-03
      - salinity:          l1=8.654e-11  l2=9.056e-13  linf=2.842e-14
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=1.297e-01  l2=4.083e-03  linf=7.529e-04
      - temperature:       l1=1.403e-07  l2=5.628e-09  linf=5.702e-10
      - salinity:          l1=5.754e-10  l2=2.717e-12  linf=5.684e-14
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.159e+01  l2=1.907e+00  linf=8.647e-01
      - salinity:          l1=3.700e+00  l2=4.494e-01  linf=2.407e-01
      - normalVelocity:    l1=1.623e+01  l2=1.591e-01  linf=6.766e-02
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.216e+01  l2=2.008e+00  linf=1.088e+00
      - salinity:          l1=3.091e+00  l2=2.534e-01  linf=1.063e-01
      - normalVelocity:    l1=1.877e+01  l2=1.834e-01  linf=8.755e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=3.010e-02  l2=2.013e-03  linf=3.364e-04
      - vertViscTopOfCell: l1=1.764e-02  l2=1.654e-03  linf=2.040e-04
      - vertDiffTopOfCell: l1=1.767e-02  l2=1.657e-03  linf=2.038e-04
      - temperature:       l1=7.037e-03  l2=9.321e-04  linf=1.750e-04
      - salinity:          l1=1.884e-04  l2=2.117e-05  linf=4.020e-06
      - layerThickness:    l1=5.478e-06  l2=7.764e-07  linf=1.486e-07
Recent commits

Polaris:

335cc496d Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7 Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cf Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: aurora
  • Compiler: intelgpu
  • Build type: Release
  • Build: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intelgpu/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intelgpu/build/ctests.log

Build warnings

No new warnings (221 in the PR build, 265 in the baseline build).

  • Baseline build log: /home/brus/run/omega_pr_test/baselines/aurora_intelgpu_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /home/brus/run/omega_pr_test/pr616-130f2c4/aurora_intelgpu/build/build_omega.log

Notes

The baseline differences in kpp_combined, the two qu240 cached_forward tasks and the overflow order 3 smoke test are expected from this PR, as on Chrysalis. It changes the pressure passed to the Brunt-Vaisala frequency in VertMix, which feeds vertical viscosity and diffusivity, and the only other commit on develop since the baseline (#622) changes machine config and docs only.

On intelgpu, the overflow order 4 del4 smoke test also differs, though it matches the baseline on intel and on Chrysalis. It uses the same vertical mixing as the order 3 test, so this is most likely the same change showing up only on the GPU, but it is worth a look.

@sbrus89

sbrus89 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Testing on pm-cpu and pm-gpu

Tested the merge of #616 (130f2c4df7) into develop (695f548841) as d4a747c70a, against Polaris' Omega submodule (23b13afac5).

Row CTests omega_pr New build warnings
pm-cpu, gnu, mpich 61 of 61 passed 30 of 34 passed, 4 with baseline differences 0
pm-gpu, gnugpu, mpich 61 of 61 passed 30 of 34 passed, 4 with baseline differences 0
pm-cpu, gnu, mpich

Polaris omega_pr suite

  • Baseline workdir: /global/homes/s/sbrus/scratch/omega_pr_test/baselines/pm-cpu_gnu_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /global/homes/s/sbrus/scratch/omega_pr_test/baselines/pm-cpu_gnu_polaris-335cc49_omega-23b13af/build
  • PR build: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-cpu_gnu/build
  • PR workdir: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-cpu_gnu/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.0.0-1373-g335cc496de-dirty)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: pm-cpu
  • Compiler: gnu
  • Build type: Release
  • Log: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-cpu_gnu/omega_pr/polaris_omega_pr.o60320591
  • Result:
    • Diffs (4 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=5.321e-02  l2=2.835e-03  linf=7.389e-04
      - temperature:       l1=1.006e-10  l2=1.947e-12  linf=3.801e-13
      - salinity:          l1=1.231e-10  l2=1.024e-12  linf=3.553e-14
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.075e+01  l2=1.853e+00  linf=8.590e-01
      - salinity:          l1=3.067e+00  l2=3.391e-01  linf=2.116e-01
      - normalVelocity:    l1=1.633e+01  l2=1.875e-01  linf=1.222e-01
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.086e+01  l2=1.797e+00  linf=1.088e+00
      - salinity:          l1=2.961e+00  l2=2.455e-01  linf=1.063e-01
      - normalVelocity:    l1=1.526e+01  l2=1.235e-01  linf=5.219e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=2.994e-02  l2=2.001e-03  linf=3.338e-04
      - vertViscTopOfCell: l1=1.792e-02  l2=1.675e-03  linf=2.048e-04
      - vertDiffTopOfCell: l1=1.796e-02  l2=1.677e-03  linf=2.046e-04
      - temperature:       l1=7.036e-03  l2=9.315e-04  linf=1.725e-04
      - salinity:          l1=1.898e-04  l2=2.144e-05  linf=4.069e-06
      - layerThickness:    l1=5.459e-06  l2=7.764e-07  linf=1.468e-07
Recent commits

Polaris:

335cc496de Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a3 Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7a Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a5 Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cfc Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: pm-cpu
  • Compiler: gnu
  • Build type: Release
  • Build: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-cpu_gnu/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-cpu_gnu/build/ctests.log

Build warnings

No new warnings (4 in the PR build, 4 in the baseline build).

  • Baseline build log: /global/homes/s/sbrus/scratch/omega_pr_test/baselines/pm-cpu_gnu_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-cpu_gnu/build/build_omega.log
pm-gpu, gnugpu, mpich

Polaris omega_pr suite

  • Baseline workdir: /global/homes/s/sbrus/scratch/omega_pr_test/baselines/pm-gpu_gnugpu_polaris-335cc49_omega-23b13af/omega_pr
  • Baseline build: /global/homes/s/sbrus/scratch/omega_pr_test/baselines/pm-gpu_gnugpu_polaris-335cc49_omega-23b13af/build
  • PR build: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-gpu_gnugpu/build
  • PR workdir: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-gpu_gnugpu/omega_pr
  • Polaris: 335cc496de995d26109d233546b18759bd1d2732 (1.0.0-1373-g335cc496de-dirty)
  • Baseline Omega: 23b13afac5f4fbf9ba18d6cec416d347e4a615f7 (Omega-v0.1.0-alpha.1-6283-g23b13afac5)
  • PR Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Machine: pm-gpu
  • Compiler: gnugpu
  • Build type: Release
  • Log: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-gpu_gnugpu/omega_pr/polaris_omega_pr.o60321672
  • Result:
    • Diffs (4 of 34):
    - ocean/planar/overflow/nonlinear/pstar/smoke_test_horiz_adv_order_3_nofct
      - normalVelocity:    l1=2.170e-02  l2=1.578e-03  linf=4.827e-04
      - temperature:       l1=5.570e-10  l2=2.963e-11  linf=5.166e-12
      - salinity:          l1=1.418e-10  l2=1.163e-12  linf=3.553e-14
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/split_explicit
      - temperature:       l1=2.159e+01  l2=1.907e+00  linf=8.647e-01
      - salinity:          l1=3.700e+00  l2=4.494e-01  linf=2.407e-01
      - normalVelocity:    l1=1.623e+01  l2=1.591e-01  linf=6.766e-02
    - ocean/spherical/realistic_global/e3sm-qu240/cached_forward/rk4
      - temperature:       l1=2.216e+01  l2=2.008e+00  linf=1.088e+00
      - salinity:          l1=3.091e+00  l2=2.534e-01  linf=1.063e-01
      - normalVelocity:    l1=1.877e+01  l2=1.834e-01  linf=8.755e-02
    - ocean/column/kpp_combined
      - normalVelocity:    l1=3.010e-02  l2=2.013e-03  linf=3.364e-04
      - vertViscTopOfCell: l1=1.764e-02  l2=1.654e-03  linf=2.040e-04
      - vertDiffTopOfCell: l1=1.767e-02  l2=1.657e-03  linf=2.038e-04
      - temperature:       l1=7.037e-03  l2=9.321e-04  linf=1.750e-04
      - salinity:          l1=1.884e-04  l2=2.117e-05  linf=4.020e-06
      - layerThickness:    l1=5.478e-06  l2=7.764e-07  linf=1.486e-07
Recent commits

Polaris:

335cc496de Merge pull request #643 from xylar/add-realistic-global-ocean-general-forward
f17d3695a3 Merge pull request #903 from xylar/fix-global-stats-anomaly-label
c3fc893b7a Merge pull request #730 from xylar/add-omega-analysis-climatology-maps
2f9888f2a5 Merge pull request #901 from xylar/update-e3sm-project-submodule
fc3cf13cfc Merge pull request #899 from xylar/restore-aurora-oneapi-2026

Baseline Omega:

23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp
ede8e22014 Merge pull request #625 from grnydawn/ykim/omega/standalone-cpu-arch-flags
eeef0a29dc Merge pull request #611 from brian-oneill/omega/analysis-restarts-and-samples

PR Omega:

d4a747c70a Test merge of E3SM-Project/Omega#616 (130f2c4df7) into develop (695f548841)
695f548841 Merge pull request #622 from sbrus89/omega/metis-root-update
23b13afac5 Merge pull request #506 from hyungyukang/omega/compute-mesh-scaling
330b297447 Merge pull request #606 from andrewdnolan/omega/optional-cout-redirect
f13879a93a Merge pull request #612 from alicebarthel/omega/add-salinity-clamp

CTest unit tests:

  • Machine: pm-gpu
  • Compiler: gnugpu
  • Build type: Release
  • Build: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-gpu_gnugpu/build
  • Omega: d4a747c70a42ef7f5868f60175480c3934a76da9 (Omega-v0.1.0-alpha.1-6289-gd4a747c70a)
  • Result: All tests passed
  • Log: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-gpu_gnugpu/build/ctests.log

Build warnings

No new warnings (852 in the PR build, 852 in the baseline build).

  • Baseline build log: /global/homes/s/sbrus/scratch/omega_pr_test/baselines/pm-gpu_gnugpu_polaris-335cc49_omega-23b13af/build/build_omega.log
  • PR build log: /global/homes/s/sbrus/scratch/omega_pr_test/pr616-130f2c4/pm-gpu_gnugpu/build/build_omega.log

Notes

The 4 baseline differences on both rows (kpp_combined, the two qu240 cached_forward tasks and the overflow order 3 smoke test) are expected from this PR, as on Chrysalis and Aurora. It changes the pressure passed to the Brunt-Vaisala frequency in VertMix, which feeds vertical viscosity and diffusivity, and the only other commit on develop since the baseline (#622) changes machine config and docs only. The pm-gpu CTests were run on an interactive node rather than in the batch queue.

@sbrus89
sbrus89 merged commit f368d66 into E3SM-Project:develop Oct 26, 2026
1 check passed
@sbrus89 sbrus89 mentioned this pull request Oct 26, 2026
Open
10 of 18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyungyukang hyungyukang hyungyukang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1st E3SM Merge

Development

Successfully merging this pull request may close these issues.

Brunt-Vaisala frequency computation in vertical mixing should be using mid-layer pressure

5 participants

@mwarusz @hyungyukang @sbrus89 @andrewdnolan @vanroekel