Multiple radiation bug fixes spotted by Claude - #440
Open
mpaiao wants to merge 4 commits into
Open
Conversation
This is a bug identified by Claude as @xiangtaoxu was working on it. There is a PFT assignment issue.
Fix albedo assignment for bedrock.
Add clumping_factor to the weighting of leaf/wood area indices for long-wave "optical" properties.
Fix mu bar calculation for diffuse radiation. This has no impact on runs as cai must be 1 for icanrad = 2. But it could become an issue if we allow for finite crown areas in the radiation scheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a series of fixes to bugs identified by Claude as @xiangtaoxu was working on it ED2 two-stream RT bugs.
Most are not severe, but one could be important when optical properties vary across PFTs.
Collaborators
@xiangtaoxu
Types of changes
Changes in Settings, Input Files or Output Files
Expectation of Answer Changes:
Changes expected in any simulation in which PFTs have different optical properties.
Checklist:
Testing :