Repository navigation
Require Company login before server selection and remove the window menu - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require global Easter Company sign-in before selecting, reopening or deep-linking to an e-server. Reuse the launcher's shared sign-in controls and account contract, supporting direct username/email/password and Microsoft/Google/Steam/Discord; new accounts finish username/password setup before unlocking the client.
Global credentials stay in the main process and OS-keyring vault, with memory-only fallback. Saved sessions are verified on startup; expiry returns to sign-in. Server connections and retries enforce the main-process gate, remote frames cannot call account IPC, and browser partitions are separated by global account as well as server origin. The global session token is never forwarded to a selected server; server PIN/access checks remain independent.
Remove the native File/Edit/View bar. Keep app controls in the tray and Ctrl+, for server selection. The default host already supports HTTPS: upgrade only its legacy HTTP/port-80 spelling to HTTPS, continuing to reject other non-test HTTP origins. The companion backend PR fixes the splash that advertised HTTP behind nginx.
Prepare version 1.0.1 for the next reviewed release. Most added lines are unchanged, provenance-pinned launcher modules; Microsoft stops at Company identity with no Minecraft authentication/entitlement/game calls or Microsoft refresh-token handover.
Validation: 16 unit tests passed (global gating, restore/revocation/expiry, keyring fallback, account setup, cancellation, secret projection, Microsoft isolation, origin/IPC and updater checks). Actual Electron keyless integration passed global login-before-server, IPC refusal before login, absence of the native menu, server PIN/Microsoft handoff and renderer isolation. Packaged first-screen checks now require sign-in controls and a hidden server-selection form; Windows/Linux build checks run on this PR. Real provider-account logins and fresh-OS installation remain manual checks.
Leave unmerged and unreleased for Owen/Delta. No deployment or tag is created by this work. See docs/COMPANY_LOGIN.md. The earlier Downloads-path fixes remain separate follow-up PRs.