Skip to content

Style the buttons of TalentTreeTweaks and TalentLoadoutManager - #2012

Closed
RedAces wants to merge 1 commit into
EllesmereGaming:mainfrom
RedAces:style-talent-tree-tweak-buttons
Closed

RedAces wants to merge 1 commit into
EllesmereGaming:mainfrom
RedAces:style-talent-tree-tweak-buttons

Conversation

@RedAces

@RedAces RedAces commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the buttons of the Addons "TalentTreeTweaks" and "TalentLoadoutManager" to the styler.

How was it tested?

Tested with 12.1 retail.
Tested with Talent Loadout Manager 1.6.34
Tested with Talent Tree Tweaks 1.13.31

Screenshots

Screenshot 2026-09-07 194147 Screenshot 2026-09-07 194137

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

@RedAces

RedAces commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

The EllesmereUIBlizzardSkin/EllesmereUIBlizzardSkin_WindowPacks.lua is close to the limit of 200 variables.

Do you want me to refactor it to put more variables into tables in order to relax this a little bit?

@RedAces
RedAces force-pushed the style-talent-tree-tweak-buttons branch from 7030a7c to a04132d Compare September 27, 2026 10:11
@EllesmereGaming

Copy link
Copy Markdown
Owner

Yo these stylizations have been intentionally left to external addons which have access to the ellesmereUI skinning api if they wish to add an ellesmereUI look

As for the variable refactor id be happy with that but it would need to be submitted as a new PR. Thanks for the contributions as always red ❤️❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants