Skip to content

Blackout Glow - #2182

Open
zanthor wants to merge 9 commits into
EllesmereGaming:mainfrom
zanthor:main
Open

zanthor wants to merge 9 commits into
EllesmereGaming:mainfrom
zanthor:main

Conversation

@zanthor

@zanthor zanthor commented Sep 23, 2026

Copy link
Copy Markdown

What does this PR do?

Adds a non-transparent glow style for those of us who have trouble seeing the default glows.

How was it tested?

Tested my CDM in multiple keys, raids, etc over the past week - 12.1 client.

Screenshots

image

In this screenshot you can see the blackout glow (solid red) being applied to several icons when I have a HotJS active.

Checklist

  • New settings default OFF (no behavior change without opt-in)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant