fix(cdm): count Demonic Healthstones on the Healthstone preset and refresh charges at once - #2258
Merged
EllesmereGaming merged 1 commit intoSep 27, 2026
Conversation
…fresh charges at once Pact of Gluttony turns self-conjured Healthstones into Demonic Healthstones, so the Healthstone preset showed 0 for warlocks with the talent. The preset now lists 224464 as a family alternate and, with the new countAllAlts flag, always shows the sum, since a warlock can hold both stones. Using or refilling a Healthstone charge moves no bag contents, so no BAG_UPDATE fires; the new count only becomes readable with BAG_UPDATE_COOLDOWN, 0.3-1.4 s after the cast. The cast's fast-lane pass had already read the old count by then, so the icon stayed stale until an unrelated edge re-armed it. BAG_UPDATE_COOLDOWN now re-reads the shown non-pot item counts, arms only on a real change and bypasses the 1 Hz cap like a cast does. Fixes EllesmereGaming#2154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2154.
BAG_UPDATEfires; the new count only becomes readable withBAG_UPDATE_COOLDOWN, 0.3-1.4 s after the cast. The cast's fast-lane pass had already read the old count by then, so the icon stayed stale until an unrelated edge re-armed it (seconds, or much longer out of combat).BAG_UPDATE_COOLDOWNnow re-reads the shown non-pot item counts, arms only on a real change, and bypasses the 1 Hz drain cap the same way a cast does.How was it tested?
Live, retail build 69933, warlock with Pact of Gluttony, this diff applied to v9.2.9 (same logic as this branch).
BAG_UPDATE_COOLDOWN0.29-0.41 s after use or conjure and 1.37 s after the Soulwell pickup; before this change the count read had already been consumed at that point.Screenshots
N/A, not a visual change: the existing count text shows the correct number.
Checklist
BAG_UPDATE_COOLDOWNwas already registered)HookScript/hooksecurefunconly, neverSetScripton Blizzard frames