Skip to content

Fix sacrificed Imp click-cast - #2259

Open
lkshrk wants to merge 1 commit into
EllesmereGaming:mainfrom
lkshrk:fix/sacrificed-imp-click-cast
Open

lkshrk wants to merge 1 commit into
EllesmereGaming:mainfrom
lkshrk:fix/sacrificed-imp-click-cast

Conversation

@lkshrk

@lkshrk lkshrk commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes click-cast bindings for a Warlock sacrificed Imp. The generated macro now casts Command Demon, which resolves to the sacrificed Imp Singe Magic action, instead of looking up the overridden spell name directly.

How was it tested?

  • Ran wow-check ~/EllesmereUI/EllesmereUIRaidFrames (0 errors).
  • Tested on live with Grimoire of Sacrifice and a sacrificed Imp; confirmed Singe Magic click-casts correctly.
  • Confirmed wow-errors --match Ellesmere is clean after reload (session 423).

Checklist

  • New settings default OFF (N/A: no settings added)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built (N/A: no feature toggle or runtime work added)
  • Cheap while enabled: event-driven (N/A: click-cast macro construction only)
  • No writes onto Blizzard-owned frames (N/A: no frames or hooks changed)
  • Tested in-game on live; no version gates or pre-Midnight APIs added

Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant