feat(raidframes): portrait 3D Zoom to a full-body view, Character Size for Inside portraits - #2260
Merged
EllesmereGaming merged 1 commit intoSep 27, 2026
Conversation
…e for Inside portraits
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two additions to the raid frame portrait's 3D mode, written by Tzahal (sent as a patched 9.2.9 build; rebased here onto current
main).SetClipsChildren(inside)), and is disabled with a tooltip otherwise.How: the model renders on a canvas the box's size times the scale, anchored to the box's bottom, and follows the box's real size through
OnSizeChanged(Inside boxes take their height from anchors). At 100% nothing changes: the model is re-anchored to the box exactly as before, with no size script set.Defaults are unchanged (3D Zoom 100, Character Size 100), so existing layouts look the same until someone moves a slider.
How was it tested?
v9.2.9tag: the change is these three files only. Applied cleanly onto currentmain(the portrait file is unchanged since 9.2.9).main: the options' Inside rule matches the runtime'sSideOf, the box clips its children for Inside positions, nothing else sets the box'sOnSizeChanged, and the 3D Zoom mapping is continuous at 300 (zoom 1, distance 3).ellesmereui-pr-checkstyle gate: clean.luac -p: clean. No new locale keys.Screenshots
Missing.
Checklist
OnSizeChangedon the addon's own portrait box while scaledHookScript/hooksecurefunconly, neverSetScripton Blizzard frames - the box and model are the addon's own frames