fix(damage-meters): prevent empty row outlines - #2264
Merged
EllesmereGaming merged 1 commit intoSep 27, 2026
Merged
EllesmereGaming merged 1 commit into
EllesmereGaming merged 1 commit into
Conversation
- Initialize row layout and colors even when class and spec data are missing. - Settle scrolling and pinned rows before populating visible content, including unresolved initial layouts. - Preserve hidden or disabled icon borders after styling and clear stale pinned data when sessions disappear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes damage meter rows that can display empty icon squares and a thin vertical line instead of their contents.
Rows now initialize correctly when class/spec information is missing or the initial window layout is unresolved. Scroll positions are adjusted before drawing a different combat segment, hidden or disabled icon borders stay hidden, and pinned rows are cleared when session data disappears.
How was it tested?
Validated the complete modified Lua file with Lua 5.1 and ran six regression cases against the actual row creation and refresh functions using mocked UI frames:
All six cases passed with the fix and failed against the original code.
Screenshots
Images captured after a clean Retail client start.
Before:

After:

Checklist