Add opt-in bonus-roll confirmation - #2265
Draft
andybergon wants to merge 3 commits into
Draft
andybergon wants to merge 3 commits into
andybergon wants to merge 3 commits into
Conversation
Default to confirming Roll only, with a cog option for Pass. Validate pending approvals against the native roll lifecycle and loot specialization; defer to BonusRollConfirm when loaded. Add Lua 5.1 lifecycle and settings tests and regenerate locale keys. Native visual and taint verification remains pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds opt-in QoL > Bonus Roll Confirmation to help avoid spending a bonus roll accidentally. The Roll prompt shows the current loot specialization. The cog's Only Confirm Roll defaults on, leaving Pass immediate; turning it off also asks before passing.
Confirmation uses EllesmereUI's popup and addon-owned buttons over the native Roll/Pass controls. Native click handlers remain unchanged. Pending approvals are invalidated when the roll, loot specialization, or settings change. The feature defers to BonusRollConfirm when that addon is loaded.
Draft while the revised click interception and combat behaviour receive in-game testing.
How was it tested?
Screenshots
Before enabling this option, the native buttons act immediately without these dialogs. Both images below show the opt-in confirmation UI, rather than a before/after comparison.
Roll confirmation with loot specialization:
Pass confirmation when Only Confirm Roll is off:
Checklist