Skip to content

feat(aurabuffreminders): add grow direction option (centered/left/right) - #2266

Merged
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
scavienger:feat/aurabuff-growth-direction
Sep 27, 2026
Merged

EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
scavienger:feat/aurabuff-growth-direction

Conversation

@scavienger

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a Grow Direction setting to AuraBuff Reminders (EllesmereUIAuraBuffReminders), allowing players to choose how the reminder row expands when buffs appear or disappear:

  • Grow Right: Anchors the left edge in place, growing rightward. When buffs are consumed/applied or expire, icons on the left stay in place, preventing cursor misclicks.
  • Grow Centered (Default): Expands symmetrically from the center (100% preserves existing behavior).
  • Grow Left: Anchors the right edge in place, growing leftward.

Key details:

  • Unlock Mode Integration: Fully synchronized with the Unlock Mode mover arrows and dropdown. Switching directions or moving anchors maintains visual position without coordinate jumping or drift.
  • Options & Preview: Added Grow Direction dropdown to Display settings (and the inline Layout Settings cog), complete with an explanatory tooltip on the label. Preview box updates live.
  • Localization: Added Korean (koKR.lua) localization matching existing EllesmereUI terminology and conventions.
  • Code Style: Pure ASCII in all core Lua files, follows W:DualRow specs with { type = "label", text = "" } for trailing slot.

How was it tested?

  • Client: Tested on live WoW client.
  • In-Game Functionality:
    • Configured missing and active reminders (food, flasks, weapon enchants, raid buffs).
    • Toggled between Grow Centered, Grow Left, and Grow Right: verified the layout aligns to the center, right, and left respectively, matching the dropdown order in both options and Unlock Mode.
    • Consumed buffs while set to Grow Right: confirmed the left edge stays anchored and remaining icons do not shift unexpectedly.
    • Tested Unlock Mode mover: moved frame, dragged anchors, and changed directions via mover dropdown/arrows. Verified /reload preserves saved positions without reverting to center.
    • Verified the explanatory tooltip triggers cleanly on the "Grow Direction" text label and does not appear redundantly over the dropdown button itself.
  • Localization: Added Korean translation in koKR.lua for the new setting and tooltip, and verified proper display on a koKR client.

Screenshots

Screenshot 2026-09-26 at 10 12 08 PM Screenshot 2026-09-26 at 9 48 07 PM Screenshot 2026-09-26 at 9 48 18 PM Screenshot 2026-09-26 at 9 48 42 PM

Checklist

  • New settings default OFF (no behavior change without opt-in) (Defaults to "Grow Centered", preserving existing behavior)
  • Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

- Add Grow Direction setting to AuraBuff Reminders (Grow Right, Grow Centered, Grow Left)
- Default to Grow Centered for zero behavior change
- Sync with Unlock Mode mover dropdown and directional arrows
- Add tooltip on label to explain edge anchoring and prevent shifting
- Add Korean localization for the new setting and tooltip
@EllesmereGaming
EllesmereGaming merged commit 5cf9e83 into EllesmereGaming:main Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants