feat(aurabuffreminders): add grow direction option (centered/left/right) - #2266
Merged
EllesmereGaming merged 1 commit intoSep 27, 2026
Merged
EllesmereGaming merged 1 commit into
EllesmereGaming merged 1 commit into
Conversation
- Add Grow Direction setting to AuraBuff Reminders (Grow Right, Grow Centered, Grow Left) - Default to Grow Centered for zero behavior change - Sync with Unlock Mode mover dropdown and directional arrows - Add tooltip on label to explain edge anchoring and prevent shifting - Add Korean localization for the new setting and tooltip
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a Grow Direction setting to AuraBuff Reminders (
EllesmereUIAuraBuffReminders), allowing players to choose how the reminder row expands when buffs appear or disappear:Key details:
Grow Directiondropdown to Display settings (and the inline Layout Settings cog), complete with an explanatory tooltip on the label. Preview box updates live.koKR.lua) localization matching existing EllesmereUI terminology and conventions.W:DualRowspecs with{ type = "label", text = "" }for trailing slot.How was it tested?
Grow Centered,Grow Left, andGrow Right: verified the layout aligns to the center, right, and left respectively, matching the dropdown order in both options and Unlock Mode.Grow Right: confirmed the left edge stays anchored and remaining icons do not shift unexpectedly./reloadpreserves saved positions without reverting to center.koKR.luafor the new setting and tooltip, and verified proper display on akoKRclient.Screenshots
Checklist
HookScript/hooksecurefunconly, neverSetScripton Blizzard frames