Skip to content

refactor(databars): split blocks into Blocks/ files - #2270

Merged
EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
Caedis:caedis/databars-blocks-split
Sep 27, 2026
Merged

EllesmereGaming merged 1 commit into
EllesmereGaming:mainfrom
Caedis:caedis/databars-blocks-split

Conversation

@Caedis

@Caedis Caedis commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

One file per block type
Shared helpers in Blocks/Shared.lua exposed via ns.BlockKit.
Block code moved verbatim, no behavior change.

How was it tested?

Tested in Forever. Loaded in with 0 issues and 0 changes.

Checklist

  • [N/A] New settings default OFF (no behavior change without opt-in)
  • [N/A] Zero cost while disabled: no events registered, no polling, no hooks doing work, no frames built
  • [N/A] Cheap while enabled: event-driven (no polling, no timer-based logic, no per-frame allocations)
  • [N/A] No writes onto Blizzard-owned frames (weak-table pattern used); HookScript/hooksecurefunc only, never SetScript on Blizzard frames
  • Tested in-game on live; no version gates or pre-Midnight APIs added

One file per block type; shared helpers in Blocks/Shared.lua exposed via
ns.BlockKit. Block code moved verbatim, no behavior change.
@Caedis

Caedis commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

May cause conflicts with other PRs that touch the _Blocks.lua file

@EllesmereGaming
EllesmereGaming merged commit def1b7c into EllesmereGaming:main Sep 27, 2026
1 check passed
@Caedis
Caedis deleted the caedis/databars-blocks-split branch September 27, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants