Skip to content

πŸ› [fix] ci: robust Chrome profile cleanup - #28

Merged
EricTechPro merged 1 commit into
mainfrom
codex/chrome-profile-cleanup
Oct 4, 2026
Merged

EricTechPro merged 1 commit into
mainfrom
codex/chrome-profile-cleanup

Conversation

@EricTechPro

Copy link
Copy Markdown
Owner

Note

Ready Β· Chrome cleanup regression reproduced and fixed

Problem

  • macOS Chrome helpers can keep writing profile files after the parent exits, making successful visual checks fail during temporary-directory cleanup.

Solution

  • Keep the existing Chrome exit wait and tolerate temporary-profile cleanup errors.
  • Add an offline regression for late profile writes and preserve launch-error reporting.

Acceptance criteria

  • A simulated ENOTEMPTY cleanup race preserves the DOM output.
  • A missing Chrome binary still raises its launch error.
  • Regression fails before the fix and passes after it.

Risk

  • Low. A profile that cannot be deleted may remain in the OS temporary directory.

- Tolerate late profile writes after Chrome exits.
- Cover cleanup races and launch-error propagation offline.
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more β†’

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account β†’

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us β†’

@EricTechPro
EricTechPro merged commit 076a1a7 into main Oct 4, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant