Skip to content

test: verify node registration before scheduling - #1769

Open
0rlych1kk4 wants to merge 3 commits into
Ericsson:masterfrom
0rlych1kk4:test/node-added-scheduling-race
Open

test: verify node registration before scheduling#1769
0rlych1kk4 wants to merge 3 commits into
Ericsson:masterfrom
0rlych1kk4:test/node-added-scheduling-race

Conversation

@0rlych1kk4

Copy link
Copy Markdown
Contributor

Adds regression coverage for the node-added scheduling path.

The test verifies that a newly added node is registered with NodeWorkerManager before ScheduleManager.createScheduleFutureForNode() is called.

This protects the ordering required to avoid scheduling a node before worker state has been initialized.

Related to #1754.

Test:
mvn -pl core.impl -am -Dtest=TestNodeLifecycleHandler -Dsurefire.failIfNoSpecifiedTests=false test

Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>
@0rlych1kk4
0rlych1kk4 requested a review from a team as a code owner August 31, 2026 13:49
@codecov-commenter

codecov-commenter commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.67%. Comparing base (9f4bd4e) to head (c8d3f3a).
⚠️ Report is 547 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #1769       +/-   ##
=============================================
- Coverage     77.45%   60.67%   -16.78%     
- Complexity     1308     1691      +383     
=============================================
  Files           135      224       +89     
  Lines          5566     9729     +4163     
  Branches        579      920      +341     
=============================================
+ Hits           4311     5903     +1592     
- Misses         1062     3508     +2446     
- Partials        193      318      +125     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants