refactor: Fix new and old codechecker script issues - #322
Conversation
ac6599e to
da767c5
Compare
nettle
left a comment
There was a problem hiding this comment.
Hi @furtib, @Szelethus,
I have added a few comments to highlight the most important bugfixes
furtib
left a comment
There was a problem hiding this comment.
Looks good!
I only have this tiny nit regarding target/exec.
|
Hi @furtib, |
furtib
left a comment
There was a problem hiding this comment.
In that case, if we expect the test actions to also be executed on the remote machines, then exec indeed seems to be the correct choice here.
LGTM!
Why:
Change #199 caused a few bugs in downstream projects.
Migration to py_binary should be fixed and refactored.
Besides codechecker.bzl and codechecker_script.py also
contained old bugs.
What: