Skip to content

refactor: move parse and related function to common - #337

Draft
furtib wants to merge 2 commits into
Ericsson:mainfrom
furtib:refactor_parse_module
Draft

furtib wants to merge 2 commits into
Ericsson:mainfrom
furtib:refactor_parse_module

Conversation

@furtib

@furtib furtib commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Why:
We want to have feature and behaviour parity between the monolithic and the per-file rule. To achieve this, we want these modules to share code where it's possible.

Related: #315

What:

  • Moved code related to parsing and severity checking to common.py.

Addresses:
none

This is to reuse these functions from the per_file script.0
@furtib furtib self-assigned this Sep 22, 2026
@furtib furtib added the non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only. label Sep 22, 2026
@furtib

furtib commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

CI fails on unchanged files.
The reason is a module name collision between the common in test/common and the common in src/common.

Since we plan on removing test/common after merging all pytest-to-Bazel PRs (#329 #298 #318), I think we should merge those and, if necessary, change the name of test/common, not this one.

@furtib
furtib marked this pull request as draft September 22, 2026 13:48

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-functional change ☮️ The patch doesn't change any functionality, e.g. refactoring, documentation, test-only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant