fix(nearest): allow returning all colors for a finite count#273
Open
spokodev wants to merge 1 commit into
Open
fix(nearest): allow returning all colors for a finite count#273spokodev wants to merge 1 commit into
spokodev wants to merge 1 commit into
Conversation
The result count was capped at one below the number of colors, so requesting a count equal to the array length dropped the farthest match. Cap at the array length instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nearest()capped the result count atarr.length - 1, so requesting a count equal to the palette size silently dropped the farthest match even though the docs say it finds the n nearest colors.nearestincludes the query color itself, so the cap has no justification. For a five-color palette,nearest(palette)('orange', 5)returned four colors instead of five.This caps at
arr.lengthso a finite count can return every color.Infinityalready returned all colors and is unchanged. Adds a test.