Skip to content

Use singular "Unassign card" copy in company cards bulk actions when one card is selected - #97396

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-companyCardsUnassignSingularCopy
Open

Use singular "Unassign card" copy in company cards bulk actions when one card is selected#97396
MelvinBot wants to merge 1 commit into
mainfrom
claude-companyCardsUnassignSingularCopy

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

The company cards bulk-action dropdown (and its unassign confirmation modal) always rendered the plural "Unassign cards" copy, regardless of how many cards were selected. So selecting exactly one card still showed the plural form, which is grammatically wrong for a single selection.

This wires the label and confirmation copy to the already-existing singular translation keys (unassignCard / unassignCardDescription) when exactly one assigned card is selected, and keeps the plural keys (unassignCards / unassignCardsDescription) otherwise. Both singular and plural keys already exist in every locale file, so no new copy was added.

  • WorkspaceCompanyCardsTableControls.tsx: added isSingleAssignedCard and used it to pick singular vs plural keys for the dropdown item text and the confirm modal title/prompt.

Fixed Issues

$ #97393
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".

Suggested steps:

  1. Open a workspace that has a direct company card feed with assigned cards.
  2. Go to Workspace settings > Company cards.
  3. Select exactly one assigned card via its checkbox and open the "1 selected" dropdown.
  4. Verify the option reads "Unassign card" (singular), and the unassign confirmation modal title/prompt use the singular copy.
  5. Select two or more assigned cards and verify the option reads "Unassign cards" (plural) with the plural confirmation copy.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Chavda Sachin <ChavdaSachin@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team July 29, 2026 21:54
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-companyCardsUnassignSingularCopy
git checkout -b claude-companyCardsUnassignSingularCopy upstream/claude-companyCardsUnassignSingularCopy
git push -u origin claude-companyCardsUnassignSingularCopy

Then you can close this PR and open a new one from your fork.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...yCardsTable/WorkspaceCompanyCardsTableControls.tsx 34.42% <25.00%> (-0.67%) ⬇️
... and 9 files with indirect coverage changes

@ChavdaSachin

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review July 29, 2026 22:05
@MelvinBot
MelvinBot requested a review from a team as a code owner July 29, 2026 22:05
@melvin-bot
melvin-bot Bot requested review from ChavdaSachin and removed request for a team July 29, 2026 22:05
@melvin-bot

melvin-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 29, 2026 22:05
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now marked Ready for review.

⚠️ Heads up: the Tests and QA Steps sections still contain the // TODO: The human co-author must fill out... placeholders, and the PR Author Checklist is unchecked. Please fill those in and complete the checklist so reviewers/QA have steps to follow.

@ChavdaSachin

ChavdaSachin commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-07-30.at.3.42.06.AM.mov

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the failing checks. All the real CI checks (tests, typecheck, lint, build, perf, etc.) are now passing. The only remaining failure is:

  • PR Author Checklist / checklist — ❌ PR Author Checklist is not completely filled out. Please check every box.

This one isn't fixable with a code change. It fails because the author checklist boxes are unchecked and the Tests / QA Steps sections still contain the // TODO placeholders. Those are human-owned items.

To make it pass, ChavdaSachin (the human co-author) needs to:

  1. Fill in the Tests and QA Steps sections (the suggested steps in the PR body can be used as a starting point).
  2. Check every box in the PR Author Checklist to confirm each item was considered.

Once that's done the checklist check will re-run and pass. There's nothing in the branch's code to fix.

@ChavdaSachin

Copy link
Copy Markdown
Contributor

@Expensify/design, does the following copy look good?

                unassignCard: 'Unassign card',
                unassignCards: 'Unassign cards',

                unassignCardDescription: 'Unassigning this card will delete all unsubmitted transactions.',
                unassignCardsDescription: 'Unassigning will delete all unsubmitted transactions from the selected cards.',

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants