Use singular "Unassign card" copy in company cards bulk actions when one card is selected - #97396
Use singular "Unassign card" copy in company cards bulk actions when one card is selected#97396MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Chavda Sachin <ChavdaSachin@users.noreply.github.com>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@MelvinBot mark this PR as ready for review |
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🤖 Done — this PR is now marked Ready for review.
|
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-07-30.at.3.42.06.AM.mov |
|
I looked into the failing checks. All the real CI checks (tests, typecheck, lint, build, perf, etc.) are now passing. The only remaining failure is:
This one isn't fixable with a code change. It fails because the author checklist boxes are unchecked and the Tests / QA Steps sections still contain the To make it pass,
Once that's done the checklist check will re-run and pass. There's nothing in the branch's code to fix. |
|
@Expensify/design, does the following copy look good? |
|
Looks good to me 👍 |
Explanation of Change
The company cards bulk-action dropdown (and its unassign confirmation modal) always rendered the plural "Unassign cards" copy, regardless of how many cards were selected. So selecting exactly one card still showed the plural form, which is grammatically wrong for a single selection.
This wires the label and confirmation copy to the already-existing singular translation keys (
unassignCard/unassignCardDescription) when exactly one assigned card is selected, and keeps the plural keys (unassignCards/unassignCardsDescription) otherwise. Both singular and plural keys already exist in every locale file, so no new copy was added.WorkspaceCompanyCardsTableControls.tsx: addedisSingleAssignedCardand used it to pick singular vs plural keys for the dropdown item text and the confirm modal title/prompt.Fixed Issues
$ #97393
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".
Suggested steps:
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari