Fix company cards bulk actions menu alignment - #97405
Open
KJ21-ENG wants to merge 2 commits into
Open
Conversation
KJ21-ENG
marked this pull request as ready for review
July 30, 2026 13:55
melvin-bot
Bot
requested review from
ChavdaSachin
and removed request for
a team
July 30, 2026 13:55
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
JmillsExpensify
and removed request for
a team
July 30, 2026 13:55
Contributor
|
@KJ21-ENG please include solutions for other blockers here. |
Contributor
Author
@ChavdaSachin Can you please take a look at my these comments to calrify that do we realy need to apply fix for them? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The company cards bulk-actions popover inherited the shared dropdown's right-side horizontal anchor. On macOS desktop, that made the menu expand left from the selected-count control and cover part of the workspace navigation.
This change gives only the company cards bulk-actions dropdown an explicit left/top anchor. The menu now expands into the company cards content area, matching the nearby Search dropdown, without changing the shared dropdown component or any card actions.
Fixed Issues
$ #97394
PROPOSAL: #97394 (comment)
Tests
No new JS console errors were produced by the tested interaction. The remote development build continued to show pre-existing Reanimated render warnings and a synthetic touch warning from the automated click.
Offline tests
N/A. This change only supplies the floating popover's desktop anchor coordinates; it does not read or write network state.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.All checklist items were reviewed as required by the PR workflow. Checked N/A items do not claim excluded platform testing: Android, iOS, offline, High Traffic, failure-input, CSS, asset, messaging, generic-component, Storybook, logged-out workspace, form-input, new-unit-test, and post-review-main-merge checks do not apply to this local desktop popover-anchor change. The applicable macOS Chromium interaction, deeplink reload, focused existing test, and design-team tag are documented above.
Screenshots/Videos
Android: Native
N/A – desktop web popover positioning only.
Android: mWeb Chrome
N/A – desktop web popover positioning only.
iOS: Native
N/A – desktop web popover positioning only.
iOS: mWeb Safari
N/A – desktop web popover positioning only.
MacOS: Chrome / Safari
Brave (Chromium) on macOS, using the exact GitHub-hosted PR build: