Skip to content

Fix company cards bulk actions menu alignment - #97405

Open
KJ21-ENG wants to merge 2 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/97394-company-cards-dropdown-alignment
Open

Fix company cards bulk actions menu alignment#97405
KJ21-ENG wants to merge 2 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/97394-company-cards-dropdown-alignment

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The company cards bulk-actions popover inherited the shared dropdown's right-side horizontal anchor. On macOS desktop, that made the menu expand left from the selected-count control and cover part of the workspace navigation.

This change gives only the company cards bulk-actions dropdown an explicit left/top anchor. The menu now expands into the company cards content area, matching the nearby Search dropdown, without changing the shared dropdown component or any card actions.

Fixed Issues

$ #97394
PROPOSAL: #97394 (comment)

Tests

  1. Open a workspace with a company card feed and at least one card.
  2. Go to Workspace settings > Company cards.
  3. Select an assigned card and open the selected-count dropdown.
  4. Verify the menu opens to the right of the selected-count control, remains inside the company cards content area, and does not cover the workspace navigation.
  5. Close the menu, select an unassigned card, and open the selected-count dropdown again.
  6. Verify the one-action menu has the same alignment and Export as CSV remains available.
  7. Refresh the company cards deeplink and repeat steps 3–6.
  • Verify that no errors appear in the JS console

No new JS console errors were produced by the tested interaction. The remote development build continued to show pre-existing Reanimated render warnings and a synthetic touch warning from the automated click.

Offline tests

N/A. This change only supplies the floating popover's desktop anchor coordinates; it does not read or write network state.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

All checklist items were reviewed as required by the PR workflow. Checked N/A items do not claim excluded platform testing: Android, iOS, offline, High Traffic, failure-input, CSS, asset, messaging, generic-component, Storybook, logged-out workspace, form-input, new-unit-test, and post-review-main-merge checks do not apply to this local desktop popover-anchor change. The applicable macOS Chromium interaction, deeplink reload, focused existing test, and design-team tag are documented above.

Screenshots/Videos

Android: Native

N/A – desktop web popover positioning only.

Android: mWeb Chrome

N/A – desktop web popover positioning only.

iOS: Native

N/A – desktop web popover positioning only.

iOS: mWeb Safari

N/A – desktop web popover positioning only.

MacOS: Chrome / Safari

Brave (Chromium) on macOS, using the exact GitHub-hosted PR build:

Company cards bulk-actions menu aligned inside the content area

@KJ21-ENG
KJ21-ENG marked this pull request as ready for review July 30, 2026 13:55
@KJ21-ENG
KJ21-ENG requested review from a team as code owners July 30, 2026 13:55
@melvin-bot
melvin-bot Bot requested review from ChavdaSachin and removed request for a team July 30, 2026 13:55
@melvin-bot

melvin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 30, 2026 13:55
@ChavdaSachin

Copy link
Copy Markdown
Contributor

@KJ21-ENG please include solutions for other blockers here.
So we could wrap it up in a single PR.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@KJ21-ENG please include solutions for other blockers here. So we could wrap it up in a single PR.

@ChavdaSachin Can you please take a look at my these comments to calrify that do we realy need to apply fix for them? Thanks!

#97406 (comment)

#97411 (comment)

#97412 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants