Skip to content

Fix - Wrong avatar is shown on the template agent after refreshing page - #97449

Merged
yuwenmemon merged 2 commits into
Expensify:mainfrom
software-mansion-labs:fix/agent-template-refresh
Jul 30, 2026
Merged

Fix - Wrong avatar is shown on the template agent after refreshing page#97449
yuwenmemon merged 2 commits into
Expensify:mainfrom
software-mansion-labs:fix/agent-template-refresh

Conversation

@jmusial

@jmusial jmusial commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Clear the persisted new-agent avatar draft when a template is picked (or "Build custom agent" is pressed) on the New agent page, so a stale draft left over from a previous session.

Fixed Issues

$ #97388
PROPOSAL:

Tests

  1. Open app
  2. Go to Account > Agents.
  3. Click New agent.
  4. Click Add on TipMaster.
  5. Refresh the page.
  6. Click RHP back button.
  7. Click Add on Translator Tess.
  8. Verify that the correct green avatar is shown when reopening Translator Tess for the second time.
  9. Click RHP back button.
  10. Click Add on Translator Tess.
  11. Verify that the correct green avatar is shown when reopening Translator Tess for the second time.

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-07-30.at.12.49.30.mov

@jmusial jmusial mentioned this pull request Jul 30, 2026
Open
7 tasks
@jmusial

jmusial commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: f40e9655fc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jmusial
jmusial marked this pull request as ready for review July 30, 2026 11:22
@jmusial
jmusial requested review from a team as code owners July 30, 2026 11:22
@melvin-bot

melvin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

@shubham1206agra @gijoe0295 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team July 30, 2026 11:22
@gijoe0295

gijoe0295 commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
Screen.Recording.2026-07-30.at.21.11.44.mov
iOS: HybridApp
iOS: mWeb Safari
Screen.Recording.2026-07-30.at.21.03.08.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-30.at.20.50.16.mov

gijoe0295
gijoe0295 approved these changes Jul 30, 2026
View reviewed changes

@gijoe0295 gijoe0295 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from yuwenmemon July 30, 2026 14:12
@yuwenmemon
yuwenmemon merged commit c696f1b into Expensify:main Jul 30, 2026
37 of 40 checks passed
@OSBotify

OSBotify commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Jul 30, 2026
@yuwenmemon @OSBotify
Merge pull request #97449 from software-mansion-labs/fix/agent-templa…
4affbb8 
…te-refresh

Fix - Wrong avatar is shown on the template agent after refreshing page

(cherry picked from commit c696f1b)

(cherry-picked to staging by marcaaron)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97449.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c696f1bb78c-9fa7295-91793bdd5b6556213b5efe88fd939b2db016892e/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c696f1b-9fa7295-b1439469f0dc572b7b0bd15f12557484273fb53e/index.html
Android iOS
Web 🕸️
https://97449.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Jul 30, 2026
Closed
@OSBotify

OSBotify commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

MelvinBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site files under docs/articles and no help site changes are required.

Why: This is an internal correctness fix. It clears a stale persisted new-agent avatar draft when a template is picked or Build custom agent is pressed on the New agent page, so the correct avatar is shown after a page refresh. It doesn't add, remove, or change any user-facing feature, label, or workflow.

The relevant published article — Create and Use Agents — documents creating, chatting with, editing, and deleting agents. None of that content describes avatar-draft persistence or the template-picker avatar behavior this PR corrects, so there's nothing to update.

No draft PR was created since no documentation update is needed.

@OSBotify

OSBotify commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

IuliiaHerets commented Jul 31, 2026

Copy link
Copy Markdown

v9.4.46-10
Windows 11 / Chrome
pass

bandicam.2026-07-31.13-42-37-496.mp4

@OSBotify

OSBotify commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.47-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

🤖 Re-reviewed — my conclusion is unchanged: no help site changes are required for this PR, so no draft PR was created.

This is an internal correctness fix that clears a stale persisted new-agent avatar draft when a template is picked or Build custom agent is pressed on the New agent page, ensuring the correct avatar shows after a page refresh. It doesn't add, remove, or change any user-facing feature, label, or workflow. The published Create and Use Agents article doesn't describe avatar-draft persistence or the template-picker avatar behavior this fix corrects, so there's nothing to update.

(See my earlier review for the same finding.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuwenmemon yuwenmemon yuwenmemon approved these changes
@shubham1206agra shubham1206agra Awaiting requested review from shubham1206agra
@heyjennahay heyjennahay Awaiting requested review from heyjennahay
+1 more reviewer
@gijoe0295 gijoe0295 gijoe0295 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jmusial jmusial

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jmusial @gijoe0295 @OSBotify @MelvinBot @IuliiaHerets @yuwenmemon