Skip to content

[No QA] Update iOS build workflows to Xcode 26.6 - #97452

Merged
mountiny merged 1 commit into
mainfrom
vit-xcode-26-6
Jul 30, 2026
Merged

[No QA] Update iOS build workflows to Xcode 26.6#97452
mountiny merged 1 commit into
mainfrom
vit-xcode-26-6

Conversation

@mountiny

@mountiny mountiny commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

All iOS build jobs in this repo select Xcode by pinning the DEVELOPER_DIR environment variable to /Applications/Xcode_26.2.app/Contents/Developer. That pin was set in Update Xcode version to 26.2 in Rock iOS build workflows in January 2026.

Since then the macOS jobs moved to Blacksmith macos-latest runners, which track the macOS 26 image and mirror the GitHub-hosted macOS 26 runner image. That image now ships Xcode 26.0.1, 26.1.1, 26.2, 26.3, 26.4.1, 26.5 (default) and 26.6 (build 17F113) — so the builds run three releases behind the image default, compiling against an older toolchain and older simulator runtimes than the runner otherwise provides. The four macOS jobs that don't set DEVELOPER_DIR are already on the image default, so the build jobs and the rest of CI disagree about which Xcode they use.

This PR bumps all five pins to /Applications/Xcode_26.6.app/Contents/Developer:

File Job(s)
.github/workflows/buildIOS.yml build — the reusable iOS build, called from deploy.yml, verifyHybridApp.yml, buildAdHoc.yml
.github/workflows/deploy.yml iosUploadTestflight and iosSubmit (Fastlane)
.github/workflows/remote-build-ios.yml build (Rock remote build matrix)
.github/workflows/publishReactNativeiOSArtifacts.yml workflow-level env, covers Build iOS Slice and Compose XCFramework

There is no single source of truth for the version — no .xcode-version file, no setup-xcode action, and workflow_call does not inherit env from the caller — so all five occurrences change together in one commit. Worth noting for reviewers: the previous two bumps each needed a follow-up commit because deploy.yml was missed, and that broke the staging deploy.

Two follow-ups are tracked in the linked issue and deliberately not done here: Mobile-Expensify/.github/workflows/lint-swift.yml is still on Xcode 16.2.0 but lives in the submodule (separate PR), and a getXcodeVersion composite action would stop this drifting again.

Fixed Issues

$ #97450

Tests

Because this PR only touches .github/**, no iOS build is triggered automatically — remote-build-ios.yml has paths-ignore: ['.github/**', ...] on its push trigger, and verifyHybridApp.yml only fires on native-source / package.json / Podfile.lock paths. The builds below must be dispatched manually against this branch.

  1. Dispatch remote-build-ios.yml against this branch with reviewed_code=true.
  2. Verify the workflow does not fail with xcode-select: error: invalid developer directory or xcrun: error: unable to find utility, which would mean Xcode 26.6 is not present on the Blacksmith image.
  3. Verify every entry in the build matrix (New Expensify Dev, Expensify Dev, and the remaining schemes) compiles successfully.
  4. Verify the Rock build log shows a genuine compile rather than an S3 remote-cache hit. A build finishing in seconds has not exercised the toolchain — in the 26.0 breakage the failures were masked by cache hits that completed in ~5 seconds.
  5. Dispatch testBuild.yml against this branch with IOS=true and REVIEWED_CODE=true to exercise the HybridApp path through buildIOS.yml.
  6. Verify the iOS ad-hoc build completes and produces an installable IPA.
  7. Install the resulting IPA on a device and verify the app launches and reaches the sign-in screen.
  • Verify that no errors appear in the JS console

Two jobs cannot be verified before merge and need watching afterwards:

  • deploy.yml (iosUploadTestflight, iosSubmit) only runs on staging / production deploys, so the first staging deploy after merge must be watched. This is the exact job that regressed on the previous two bumps.
  • publishReactNativeiOSArtifacts.yml is workflow_call-only and runs via publishReactNativeArtifacts.yml; confirm the next artifact-publish run on main produces the XCFramework.

Offline tests

N/A — this changes CI workflow configuration only and has no runtime or network behavior.

QA Steps

[No QA] — this is a CI infrastructure change with no user-facing behavior.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Not yet tested — needs manual QA.

Android: mWeb Chrome

Not yet tested — needs manual QA.

iOS: Native

Not yet tested — needs manual QA.

iOS: mWeb Safari

Not yet tested — needs manual QA.

MacOS: Chrome / Safari

Not yet tested — needs manual QA.

@mountiny
Update iOS build workflows to Xcode 26.6
2b532bc 
All iOS build jobs selected Xcode by pinning DEVELOPER_DIR to Xcode_26.2.app,
set back in January when 26.2 became the runner image default. Since then the
macOS jobs moved to Blacksmith macos-latest, which tracks the macOS 26 image
where Xcode 26.5 is the default and 26.6 is the newest available.

This bumps all five pins to Xcode_26.6.app so the iOS builds use the newest
toolchain and simulator runtimes on the image instead of running three releases
behind it:

- buildIOS.yml (reusable build, called from deploy/verifyHybridApp/buildAdHoc)
- deploy.yml (iosUploadTestflight and iosSubmit Fastlane jobs)
- remote-build-ios.yml (Rock remote build matrix)
- publishReactNativeiOSArtifacts.yml (workflow-level env for both jobs)

There is no single source of truth for the version, so all occurrences change
together. The previous two bumps each shipped as a follow-up commit because
deploy.yml was missed, which broke the staging deploy.
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97452.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2b532bcadfc-9bd7578-0466866e3cc026f86b3211ed47f2a44ce7e2d1b9/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2b532bc-9bd7578-bade593e68e86c48b4377b3073e3c469fafd9668/index.html
Android iOS
Web 🕸️
https://97452.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@mountiny

mountiny commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Tested the ios build and its all fine

@mountiny
mountiny marked this pull request as ready for review July 30, 2026 14:54
@mountiny
mountiny requested a review from a team as a code owner July 30, 2026 14:54
@melvin-bot
melvin-bot Bot requested review from rojiphil and removed request for a team July 30, 2026 14:54
@melvin-bot

melvin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
mountiny removed the request for review from rojiphil July 30, 2026 14:54
@lakchote

lakchote commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@mountiny
mountiny merged commit 4fca377 into main Jul 30, 2026
30 checks passed
@mountiny
mountiny deleted the vit-xcode-26-6 branch July 30, 2026 15:16
@OSBotify

OSBotify commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 31, 2026
Open
49 tasks
@OSBotify

OSBotify commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.47-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjasikowski mjasikowski mjasikowski approved these changes
@lakchote lakchote lakchote approved these changes

Assignees

@mountiny mountiny

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mountiny @lakchote @OSBotify @mjasikowski