Strip new magic codes instances - #97457
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e91c1959e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| import getWalletPersonalDetailsParams from '@pages/EnablePayments/shared/getWalletPersonalDetailsParams'; | ||
| import IdologyQuestions from '@pages/EnablePayments/shared/IdologyQuestions'; | ||
| import useWalletPhoneMagicCode from '@pages/EnablePayments/shared/useWalletPhoneMagicCode'; | ||
| import useWalletPhoneValidateCode from '@pages/EnablePayments/shared/useWalletPhoneValidateCode'; |
There was a problem hiding this comment.
This new import points at @pages/EnablePayments/shared/useWalletPhoneValidateCode, but this commit deletes useWalletPhoneMagicCode.ts without adding a useWalletPhoneValidateCode.ts replacement (the shared directory in the reviewed tree has no such file). As soon as the enable-payments personal-details pages or the updated unit test are loaded, module resolution fails and the KYC flow cannot render.
Useful? React with 👍 / 👎.
| }, | ||
| [SCREENS.SETTINGS.WALLET.ENABLE_PAYMENTS_CONFIRM_MAGIC_CODE]: { | ||
| path: ROUTES.SETTINGS_ENABLE_PAYMENTS_CONFIRM_MAGIC_CODE.route, | ||
| [SCREENS.SETTINGS.WALLET.ENABLE_PAYMENTS_CONFIRM_VALIDATE_CODE]: { |
There was a problem hiding this comment.
SCREENS.SETTINGS.WALLET.ENABLE_PAYMENTS_CONFIRM_VALIDATE_CODE is not defined in src/SCREENS.ts (the navigator/types/RHP relation still use ENABLE_PAYMENTS_CONFIRM_MAGIC_CODE). In the transpiled app this creates an undefined key in the linking config, so settings/wallet/enable-payments/confirm-validate-code is not mapped to the mounted wallet confirmation screen and navigation to the new URL cannot resolve correctly.
Useful? React with 👍 / 👎.
|
@joekaufmanexpensify, this is a follow-up to an existing PR, don't think we need a product review here 🙇 |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
NikkiWines
changed the title
|
HELD pending #97278 |
NikkiWines
changed the title
|
Off hold now |
1 participant
Explanation of Change
Follow up to #96181 - replaces new instances of magic code usage since that was released
Fixed Issues
$ Tied to #96180
PROPOSAL:
Tests
N/A small find + replace
Offline tests
N/A
QA Steps
N/A small find + replace
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari