Fix/96314 deleted linked action flash - #97458
Open
yusufdeveloper2903 wants to merge 2 commits into
Open
Conversation
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
July 30, 2026 11:23
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a deep link points to a report action that has been deleted (or is otherwise not visible),
LinkedActionNotFoundGuardused to render aFullPageNotFoundView("hmm... it's not here"). On native this caused a brief flash of the "not found" page before the auto-recovery effect could run (NativeStackViewcommits UI synchronously before the effect fires), and the behavior was inconsistent when opening the link from a self DM.This PR removes the unreachable "not found" page entirely. The guard now only runs the recovery effects and returns
children. When the linked action is not found,useAutoNavigateForDeletedLinkedActionclears the stalereportActionIDparam in auseLayoutEffect(runs before paint), so the user is taken straight to the end of the report with no flash and consistent behavior across entry points.Fixed Issues
$ #96314
PROPOSAL: #96314 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
After fix:
REC-20260730161758.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari