Skip to content

chore: track upstream SRT master fix (Haivision/srt#3354, closed 09-15) for #91, and #90 still awaits merge #93

Description

@alexbj75

Context

Haivision/srt#3354 (the upstream heap-corruption/hang bug behind node-srt#91, "AsyncSRT.dispose()/
worker.terminate() causes native heap corruption") was closed 2026-09-15. The maintainer's comment thread
confirms: rebuilt against current master (cae8f624), the same repro suite that previously crashed reliably ran
6/6 clean.

The gap

The latest tagged release, v1.5.7 (published 2026-08-28), predates the 09-15 fix confirmation on
master. No tag yet contains the fix, so node-srt#91 cannot be closed by re-pinning to an existing release.

Separately, node-srt#90 (bump bundled libSRT v1.5.5 -> v1.5.6, fixing CVE-2026-55869 / CVE-2026-55868) is
unrelated to #91 and has sat open since 2026-08-13: mergeable: MERGEABLE, mergeStateStatus: UNSTABLE, and
is explicitly flagged in its own body as a "Tier B" native-build change awaiting a human maintainer rather than
auto-merge, even with the CVE fix verified.

Ask

  1. Track Haivision/srt for the next tagged release containing cae8f624 (or later); when it lands, re-verify
    AsyncSRT.dispose()/worker.terminate() causes native heap corruption (reproduces on v1.5.5 and v1.5.6) #91's repro against it and update scripts/build-srt-sdk.js's SRT_CHECKOUT pin accordingly.
  2. Separately, Bump bundled libSRT to v1.5.6 (fixes CVE-2026-55869, CVE-2026-55868) #90 is CI-green and CVE-verified; it just needs the named human merge decision it has been
    waiting 35 days for.

Actionability

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requestedready-for-maintainerReviewed by triage bot; awaiting human merge

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions