Repository navigation
GenericController cleanup - #1016
Merged
Merged
Conversation
dennisvang
force-pushed
the
dev/generic-controller-cleanup
branch
2 times, most recently
from
September 25, 2026 15:27
7763945 to
87c11d2
Compare
dennisvang
added this pull request to stack #1019
September 25, 2026 15:54
and add more explanatory comments
because in an upcoming change we want to allow non-paged children as well
so we can reuse the logic
…s etc. note we use 'Uri' naming instead of the actual 'IRI', to remain consistent with the existing code base
Assisted-by: junie
not strictly required, but prevents redundant conversion Assisted-by: junie
to prevent redundant string formatting Assisted-by: junie
clarifies that titles is independent of entity
for sorting child URIs by title
based on my interpretation of what is does
makes the filter easier to read
dennisvang
force-pushed
the
dev/generic-controller-cleanup
branch
from
September 29, 2026 12:58
c255339 to
1fac5ba
Compare
it is called Metadata (single capital) throughout the code base, not MetaData (double capital)
and make the method package-private so the test has access
with the help of SpringJUnitConfig and MockitoBean this also fixes the interdependence issue that arose when using @SpringBootTest, where the test passed when running individually, but failed when running in a suite
dennisvang
marked this pull request as ready for review
September 30, 2026 09:47
dennisvang
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenericControllerto constructor injection with the help of lombok@RequiredArgsConstructorgetMetaDataChildrengetResourceNameForChildtogetUrlPrefixand simplifiedcreateLink*tocreatePagingLink*for claritygetMetadataChildrencontroller method into separategetChildResourceUrismethodGenericControllerTestwith test forgetChildResourceUristodo:
follow-up: port #844 to the
masterbranchAssisted-by: Junie Copilot
AI disclosure: Junie was used as a sanity check for my hand-made changes, resulting in some minor optimizations. Copilot (free) was used to review the PR, in the absence of any human reviewers.