Clean up MetadataEnhancer - #1030
Merged
Merged
Conversation
with the help of lombok RequiredArgsConstructor
in all MetadataEnhancer methods
- filter out null values - replace .collect(Collectors.toList()) with .toList() because it is simpler and we don't need a mutable list
based on my interpretation of what they currently do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General cleanup of the
MetadataEnhancerclass, without changing functionality.@RequiredArgsConstructor@Valueannotations to generated constructorscreateMetadataIdentifierThis helps me understand the
MetadataEnhancerinternals, in preparation for taking on #854 and #605 (possibly also #858).Assisted-by: copilot
AI disclosure: Copilot (free) was used to find the list of defaults for `lombok.copyableAnnotations` in the lombok source code, and for a final sanity check (no changes).