Skip to content

Clean up MetadataEnhancer - #1030

Merged
dennisvang merged 7 commits into
masterfrom
dev/metadata-enhancer-cleanup
Oct 2, 2026
Merged

dennisvang merged 7 commits into
masterfrom
dev/metadata-enhancer-cleanup

Conversation

@dennisvang

@dennisvang dennisvang commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

General cleanup of the MetadataEnhancer class, without changing functionality.

  • switched to constructor autowiring with the help of lombok @RequiredArgsConstructor
  • configured lombok to copy @Value annotations to generated constructors
  • removed single-use method createMetadataIdentifier
  • added javadocs for all methods, based on my interpretation of what the code actually does

This helps me understand the MetadataEnhancer internals, in preparation for taking on #854 and #605 (possibly also #858).

Assisted-by: copilot

AI disclosure: Copilot (free) was used to find the list of defaults for `lombok.copyableAnnotations` in the lombok source code, and for a final sanity check (no changes).

with the help of lombok RequiredArgsConstructor
- filter out null values
- replace .collect(Collectors.toList()) with .toList() because it is simpler and we don't need a mutable list
based on my interpretation of what they currently do
@dennisvang dennisvang added maintenance Maintenance dev Related to development, e.g. code style, refactoring, github workflows, etc. labels Oct 2, 2026
@dennisvang
dennisvang merged commit 1abe194 into master Oct 2, 2026
14 checks passed
@dennisvang
dennisvang deleted the dev/metadata-enhancer-cleanup branch October 2, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Related to development, e.g. code style, refactoring, github workflows, etc. maintenance Maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant