Repository navigation
Shift before truncating block starts in binary_fuse8_populate (fixes #80) - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80.
binary_fuse8_populatecasti * sizeto 32 bits before shifting byblockBits, so the product wrapped once it reached 2^32 (from about 8.4M keys). Wrapped block starts land inside the low blocks, so placement walks many blocks before finding a free slot. The filter stayed correct, but populate got much slower. This applies the parenthesization already used inbinary_fuse16_populate:At 20M keys (
-O3, Apple silicon, one run), fuse8 populate goes from 120.9 ns/key to 27.2 ns/key, and every key is still contained.make unit && ./unitpasses.