Skip to content

fix: upgrade minecraft pinger, use i32 instead u32 - #114

Merged
Flash303 merged 4 commits into
mainfrom
dev
Oct 21, 2026
Merged

Flash303 merged 4 commits into
mainfrom
dev

Conversation

@Flash303

Copy link
Copy Markdown
Owner

This pull request makes several improvements and refactors across the repository crate, focusing on type consistency, code readability, and maintainability. The most significant changes include standardizing integer types for server-related timestamps and values, reorganizing module imports for clarity, and reformatting code for better readability. Additionally, there are minor dependency updates and some bugfixes related to type usage.

Type consistency and bugfixes:

  • Changed various struct fields and function signatures from u32 to i32 for last_connected, RecordData, and related values to ensure consistency with database types and prevent potential bugs. (backend/crates/repository/src/models/record.rs [1] [2]; backend/crates/repository/src/models/server.rs [3] [4]; backend/crates/repository/src/postgres.rs [5] [6]
  • Updated function signatures and internal logic in the repository implementation to use i32 where appropriate for ping and server values. (backend/crates/repository/src/postgres.rs [1] [2]

Code organization and readability:

  • Reorganized module imports and declarations for clarity and consistency, especially in lib.rs, mod.rs, and postgres.rs. (backend/crates/repository/src/lib.rs [1]; backend/crates/repository/src/models/mod.rs [2]; backend/crates/repository/src/postgres.rs [3]
  • Reformatted and expanded multi-line function calls, conditionals, and queries to improve code readability and maintainability throughout the duplicate detection and repository modules. (backend/crates/repository/src/duplicate_detection.rs [1] [2] [3] [4] [5]; backend/crates/repository/src/postgres.rs [6] [7] [8] [9] [10] [11] [12] [13]

Dependency and enum improvements:

Import and ordering fixes:

These changes collectively improve the maintainability, correctness, and style consistency of the codebase.

@Flash303
Flash303 merged commit 91ff64a into main Oct 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant