Fix potential problem getenv in windows.#3
Merged
Conversation
fundeliciousjelly
changed the title
Owner
|
Hi there @fundeliciousjelly . I did knew that std::getenv was deprecaed in Win32 (maybe other methods) and thank you for providing me the solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
So I read the source code, and I came to notice std::getenv in windows.
getenv in windows (in msvc), doesn't support universal windows platform apps, means getenv cannot be ran in windows runtime.
but it also create lots of mappings based on the windows environment like
Hence, the safest approach is to use the
GetEnvironmentVariableA, from windows.h, and lives in kernel32.lib, as it support any windows regardless if its universal or not.