Skip to content

Add fixes for linter issues uncovered by dependabot upgrade of neostandard - #8994

Merged
n-lark merged 1 commit into
mainfrom
fix-lint-for-dependabot
Oct 20, 2026
Merged

n-lark merged 1 commit into
mainfrom
fix-lint-for-dependabot

Conversation

@n-lark

@n-lark n-lark commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Description

Clears the lint errors that neostandard 0.14 surfaces, ahead of #8976, so that PR stays a clean three-package bump rather than a bump plus source changes.

  • snapshots.js, avatar.js — indentation. @Stylistic 5 checks continuation lines that version 2 ignored.
  • account-settings.spec.js — renamed a cb param. eslint-plugin-n 18 fires no-callback-literal on anything named cb, which is a false positive here: it's a PostHog feature-flag callback, not a Node errback.
  • 3 × *.subscriber.spec.js — dropped /* eslint-env browser */. Already redundant, since the config sets globals.browser for test/unit/frontend/**. These become hard errors in eslint 10, so this also unblocks build(deps-dev): bump eslint from 9.39.4 to 10.13.0 #8785.

Related Issue(s)

N/A

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this Oct 20, 2026
@n-lark
n-lark enabled auto-merge (squash) October 20, 2026 15:17
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.45%. Comparing base (084cbb7) to head (11dbf9e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
forge/routes/ui/avatar.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8994   +/-   ##
=======================================
  Coverage   79.45%   79.45%           
=======================================
  Files         475      475           
  Lines       26016    26016           
  Branches     6934     6934           
=======================================
  Hits        20670    20670           
  Misses       5346     5346           
Flag Coverage Δ
backend 79.45% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@n-lark
n-lark merged commit 790d2f2 into main Oct 20, 2026
36 of 38 checks passed
@n-lark
n-lark deleted the fix-lint-for-dependabot branch October 20, 2026 15:30

This branch was successfully deployed

1 active deployment
staging — 11dbf9ef Deployed Oct 20, 2026 by n-lark via Remove application #12619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants