Skip to content

Fix linter error for new cap rule from eslint upgrade - #8998

Merged
n-lark merged 1 commit into
mainfrom
fix-lint-new-cap
Oct 20, 2026
Merged

n-lark merged 1 commit into
mainfrom
fix-lint-new-cap

Conversation

@n-lark

@n-lark n-lark commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Description

Clears the one lint error eslint 10 surfaces, ahead of #8785, so that PR stays a clean bump.

eslint 10 tightens new-cap, which now flags new first.constructor(...) — a false positive, since .constructor is lowercase by definition. Assigning it to Ctor first satisfies the rule without a disable comment or a config-wide properties: false.

Related Issue(s)

N/A

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@n-lark n-lark self-assigned this Oct 20, 2026
@n-lark
n-lark enabled auto-merge (squash) October 20, 2026 17:09
@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.44%. Comparing base (44f3ce0) to head (ff58da6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8998   +/-   ##
=======================================
  Coverage   79.44%   79.44%           
=======================================
  Files         475      475           
  Lines       26017    26017           
  Branches     6934     6934           
=======================================
  Hits        20670    20670           
  Misses       5347     5347           
Flag Coverage Δ
backend 79.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@n-lark
n-lark merged commit 5cf2900 into main Oct 20, 2026
36 of 38 checks passed
@n-lark
n-lark deleted the fix-lint-new-cap branch October 20, 2026 17:46

This branch was successfully deployed

1 active deployment
staging — ff58da68 Deployed Oct 20, 2026 by n-lark via Remove application #12629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants