Repository navigation
Fix broken S7 link on /node-red/ and link certified nodes straight to their docs - #5937
Merged
Merged
Conversation
The certified-nodes catalogue feeds still give the old /node-red/flowfuse/... URLs as each node's docs link. The new S7 node has no redirect from that old path, so the /node-red/ card linked to a page that does not exist and the link checker failed on main. Override every certified node's docs URL with its /docs/flowfuse-nodes/ path, so the cards no longer depend on the old redirects.
✅ Deploy Preview for flowfuse-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thanks @sumitshinde-84 & @n-lark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainis failing the Build and check job (run) on one broken link:The certified node cards on
/node-red/use the docs URL from the certified-nodes catalogue feeds. Those feeds still give the old/node-red/flowfuse/...paths. The older nodes worked only because each old path has a 301 innuxt/redirects-node-red.ts. S7 was added in #5922 and never had a page at the old path, so its card linked to a page that does not exist.What changed
DOCS_URL_OVERRIDESinnuxt/utils/integrations.tsalready pointed OPC UA at its docs page. Every certified node is now listed there, so each card links straight to its current page:/node-red/flowfuse/edge/cip-suite/docs/flowfuse-nodes/edge/cip-suite//node-red/flowfuse/hub/kafka//docs/flowfuse-nodes/hub/kafka//node-red/flowfuse/edge/modbus//docs/flowfuse-nodes/edge/modbus//node-red/flowfuse/hub/redis/docs/flowfuse-nodes/hub/redis//node-red/flowfuse/edge/rtsp//docs/flowfuse-nodes/edge/rtsp//node-red/flowfuse/edge/s7//docs/flowfuse-nodes/edge/s7/This fixes the broken S7 link. For the other five, clicks now skip the redirect.
Not changed
nuxt/redirects-node-red.tsstay. Old bookmarks and links from other sites still use those URLs.